[048/173] fs/buffer.c: add checking buffer head stat before clear

Commit Message

Andrew Morton Feb. 24, 2021, 8:02 p.m. UTC

From: Yang Guo <[e-mail]>
Subject: fs/buffer.c: add checking buffer head stat before clear

clear_buffer_new() is used to clear buffer new stat.  When PAGE_SIZE is
64K, most buffer heads in the list are not needed to clear. 
clear_buffer_new() has an enpensive atomic modification operation, Let's
add checking buffer head before clear it as __block_write_begin_int does
which is good for performance.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Yang Guo <[e-mail]>
Signed-off-by: Shaokun Zhang <[e-mail]>
Cc: Alexander Viro <[e-mail]>
Cc: Nick Piggin <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 fs/buffer.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

--- a/fs/buffer.c~fs-bufferc-add-checking-buffer-head-stat-before-clear
+++ a/fs/buffer.c
@@ -2083,7 +2083,8 @@  static int __block_commit_write(struct i
 			set_buffer_uptodate(bh);
 			mark_buffer_dirty(bh);
 		}
-		clear_buffer_new(bh);
+		if (buffer_new(bh))
+			clear_buffer_new(bh);
 
 		block_start = block_end;
 		bh = bh->b_this_page;