| Message ID | 20220609221702.347522-2-morbo@google.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Clang -Wformat warning fixes | expand |
On 6/9/22 15:16, Bill Wendling wrote: > From: Bill Wendling <isanbard@gmail.com> > > When compiling with -Wformat, clang emits the following warnings: > > arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > panic(msg); > ^~~ > > Use a string literal for the format string. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Bill Wendling <isanbard@gmail.com> > --- > arch/x86/kernel/cpu/mce/core.c | 2 +- > scripts/Makefile.extrawarn | 4 ++-- Where is the scripts/ change? > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > index 2c8ec5c71712..3d411b7c85ad 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) > if (!fake_panic) { > if (panic_timeout == 0) > panic_timeout = mca_cfg.panic_timeout; > - panic(msg); > + panic("%s", msg); > } else > pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg); >
On Thu, Jun 9, 2022 at 4:15 PM Randy Dunlap <rdunlap@infradead.org> wrote: > On 6/9/22 15:16, Bill Wendling wrote: > > From: Bill Wendling <isanbard@gmail.com> > > > > When compiling with -Wformat, clang emits the following warnings: > > > > arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > > panic(msg); > > ^~~ > > > > Use a string literal for the format string. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > > Signed-off-by: Bill Wendling <isanbard@gmail.com> > > --- > > arch/x86/kernel/cpu/mce/core.c | 2 +- > > scripts/Makefile.extrawarn | 4 ++-- > > Where is the scripts/ change? > I'm sorry about this. The change in that file was a mistake that I reverted, but I forgot to change this part. -bw > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > > index 2c8ec5c71712..3d411b7c85ad 100644 > > --- a/arch/x86/kernel/cpu/mce/core.c > > +++ b/arch/x86/kernel/cpu/mce/core.c > > @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) > > if (!fake_panic) { > > if (panic_timeout == 0) > > panic_timeout = mca_cfg.panic_timeout; > > - panic(msg); > > + panic("%s", msg); > > } else > > pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg); > > > > -- > ~Randy
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 2c8ec5c71712..3d411b7c85ad 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) if (!fake_panic) { if (panic_timeout == 0) panic_timeout = mca_cfg.panic_timeout; - panic(msg); + panic("%s", msg); } else pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg);