Message ID | 20220609221702.347522-5-morbo@google.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C21C43334 for <linux-mm@archiver.kernel.org>; Thu, 9 Jun 2022 22:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDA098D0054; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D890A8D0034; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C028C8D0054; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A9A7B8D0034 for <linux-mm@kvack.org>; Thu, 9 Jun 2022 18:18:49 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 857C661728 for <linux-mm@kvack.org>; Thu, 9 Jun 2022 22:18:49 +0000 (UTC) X-FDA: 79560113178.26.A413A8C Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf16.hostedemail.com (Postfix) with ESMTP id 232F2180057 for <linux-mm@kvack.org>; Thu, 9 Jun 2022 22:18:48 +0000 (UTC) Received: by mail-pj1-f74.google.com with SMTP id t11-20020a17090a2f8b00b001ea6a226d21so262713pjd.8 for <linux-mm@kvack.org>; Thu, 09 Jun 2022 15:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=HlrKEzC+OauxSUT5xZtPYeK0f3N3z3B8pf9PvEyK7vc=; b=qNUPK/S5iHdXgPK57Bkixsq++QOQQMHfyV6r2MtPs7v9I3SUg8azHVdlWi+Vmpdk0V e9swXJWEpf/dXShWMQkD9tdieecIjQpQiuIyNIyGp6c4DhP+OHtn6lVN3Jb0aUWnt0zX 6WRDoSX5skQyQJy1DXGgbB1frbSREBbKFeP8ovCXNP1nwpzQihNeuZDVsxzVVQEW/FTO oasKzV38q06qXK4hlfrcDIvuu6az9YMh+LOMOYwAEM/GaKPtPsyF6cfogObTYmCvxbsF HDhlFK8BOzg5MG7pql3z3B69jG4uxkigcwMhH0FMhZG9+AiHWiMvxTL/b/XFzI/yrt60 XE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=HlrKEzC+OauxSUT5xZtPYeK0f3N3z3B8pf9PvEyK7vc=; b=5i0Z0Y/sE9MZtkxnbsAWaMIyXjzdnj+Wjjoo1T/unz4E+21Z4752xPNpMQLzA35m+W TYoM3JVY4utNQNLi3sFPH6S0IhSPTZCmK5Nj5CgOgGWIHYgEkv4SmVrbjOxA6qtQ1jnZ AXLJHAGmTs+ucZvygtI5mGrT6CIldR6GyyPzINeDrJsW4jcGiN7C0kYtl6YML16xHc5e VHQEWRf/EaEV07Q4sqPlebR8EUorfjHLPh0JlWCuaVxqdvE90sTNIzaQpQgF5Teu+Zcj JvK22+SgCZLZFP39AsE1z6CJZDa7IlKuRejB9KebU3XW5bbt1U0gmeA/JkjQnKJv7KZF BDAg== X-Gm-Message-State: AOAM531z0fNiP2Z/MsTXnPOkMbbkQVfXVgrod+WTHTUmddecxa/jr10a ZTTZiPOAnNOo7+dbM/r/e0NBtD/e X-Google-Smtp-Source: ABdhPJxktSZZjGsZMg+ncs7oCo7UsGcqz2MItXnZVpN7aAWxKCb/sSBN71lrVJLJ6nxui+334t4TDARu1w== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a63:5924:0:b0:3fb:a75e:9e8a with SMTP id n36-20020a635924000000b003fba75e9e8amr36694755pgb.394.1654813127925; Thu, 09 Jun 2022 15:18:47 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:23 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-5-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 04/12] blk-cgroup: use correct format characters From: Bill Wendling <morbo@google.com> To: isanbard@gmail.com Cc: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, Phillip Potter <phil@philpotter.co.uk>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Jan Kara <jack@suse.com>, Andrew Morton <akpm@linux-foundation.org>, Pablo Neira Ayuso <pablo@netfilter.org>, Jozsef Kadlecsik <kadlec@netfilter.org>, Florian Westphal <fw@strlen.de>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, Ross Philipson <ross.philipson@oracle.com>, Daniel Kiper <daniel.kiper@oracle.com>, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813129; a=rsa-sha256; cv=none; b=NE4yy7t2mysw/NrEHtQ9mtIfL0CO+JeLKUk20NRKgJnzjnVrvKOGkmxiLzC/7FQhg0cQOX 7o9Okh4OayQjbqe8gu7LIRHIEA7MBPLMI5dpdliFC+BNgvQ49mAAlzdPUNYhBk6doTdil8 E4tXtgcnaorCZRG+hbCOgYC6FqcS7yc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qNUPK/S5"; spf=pass (imf16.hostedemail.com: domain of 3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlrKEzC+OauxSUT5xZtPYeK0f3N3z3B8pf9PvEyK7vc=; b=5Hn0jzUQ6AsWzyhperDYRVZdgZDoIv7iZ12azt8+YdRhwMedFoXUyuwxAPBk7viEZApnWh 39DppUPL9BGlUdF9E8uzrC3EB/kg5uj6W0TDZdQTaUx59G6Eco6GEyXEPR5rAWZs4vEoPp pspTJGab9/nmRz2mfbjwO6m0YW5nkd8= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 232F2180057 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qNUPK/S5"; spf=pass (imf16.hostedemail.com: domain of 3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3x3GiYgUKCFA469t6y66y3w.u64305CF-442Dsu2.69y@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: u6e1uo3asekypfp738t3re8tp7fpfjns X-HE-Tag: 1654813128-609726 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
Clang -Wformat warning fixes
|
expand
|
On Thu, Jun 09, 2022 at 10:16:23PM +0000, Bill Wendling wrote: > vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args); > - dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); > + dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, "%s", bdi->dev_name); Please avoid the overly long line. But given that bdi names aren't user input this warning seems to shoot from the hip a bit.
diff --git a/mm/backing-dev.c b/mm/backing-dev.c index ff60bd7d74e0..7b7786dceff3 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -877,7 +877,7 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args) return 0; vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args); - dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); + dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, "%s", bdi->dev_name); if (IS_ERR(dev)) return PTR_ERR(dev);