[00/19] Covertity Scan: Removed resources leaks

Message

Steve Dickson May 8, 2019, 1:35 p.m. UTC

Red Hat is now requiring covertity scans 
to be run against all RHEL 8 packages. 

These patches removed the majority of the 
resource leaks that were flagged by the scan.

Most of the leaks were in return and error
paths as well as some obvious problems like
checking the wrong point to be NULL. 

There are still a few resources leaks 
and used_after_freed being flagged but
I am thinking they false-positives 
because I just don't see the problem. 

I've tested these patches for a couple
days and they seem stable... but whenever
free()s are added... So is risk of freeing
that is still being used. Plus they will
get a good workout at the upcoming Bakeathon.

Steve Dickson (19):
  Removed resource leaks from junction/path.c
  Removed resource leaks from nfs/exports.c
  Removed a resource leak from nfs/mydaemon.c
  Removed a resource leak from nfs/rpcmisc.c
  Removed a resource leak from nfs/svc_socket.c
  Removed bad frees from nfs/xcommon.c
  Removed resource leaks from nfs/xlog.c
  Removed resource leaks from nfsidmap/libnfsidmap.c
  Removed resource leaks from nfsidmap/static.c
  Removed a resource leak from nsm/file.c
  Removed resource leaks from systemd/rpc-pipefs-generator.c
  Removed resource leaks from blkmapd/device-discovery.c
  Removed resource leaks from gssd/krb5_util.c
  Removed a resource leak from mount/configfile.c
  Removed a resource leak from mount/nfsmount.c
  Removed a resource leak from mount/stropts.c
  Removed resource leaks from mountd/cache.c
  Removed a resource leak from mountd/fsloc.c
  Removed a resource leak from nfsdcltrack/sqlite.c

 support/junction/path.c          |  6 +++++-
 support/nfs/exports.c            |  2 ++
 support/nfs/mydaemon.c           |  1 +
 support/nfs/rpcmisc.c            |  1 +
 support/nfs/svc_socket.c         |  1 +
 support/nfs/xcommon.c            | 14 ++++++++++----
 support/nfs/xlog.c               |  6 +++++-
 support/nfsidmap/libnfsidmap.c   | 10 ++++++++--
 support/nfsidmap/static.c        | 10 ++++++++++
 support/nsm/file.c               |  1 +
 systemd/rpc-pipefs-generator.c   | 10 ++++++++--
 utils/blkmapd/device-discovery.c | 22 +++++++++++++++++++++-
 utils/gssd/krb5_util.c           |  9 ++++++++-
 utils/mount/configfile.c         |  2 +-
 utils/mount/nfsmount.c           |  1 +
 utils/mount/stropts.c            |  5 ++++-
 utils/mountd/cache.c             |  5 +++--
 utils/mountd/fsloc.c             |  1 +
 utils/nfsdcltrack/sqlite.c       |  2 ++
 19 files changed, 93 insertions(+), 16 deletions(-)

Comments

Steve Dickson May 10, 2019, 3:07 p.m. UTC | #1

On 5/8/19 9:35 AM, Steve Dickson wrote:
> Red Hat is now requiring covertity scans 
> to be run against all RHEL 8 packages. 
> 
> These patches removed the majority of the 
> resource leaks that were flagged by the scan.
> 
> Most of the leaks were in return and error
> paths as well as some obvious problems like
> checking the wrong point to be NULL. 
> 
> There are still a few resources leaks 
> and used_after_freed being flagged but
> I am thinking they false-positives 
> because I just don't see the problem. 
> 
> I've tested these patches for a couple
> days and they seem stable... but whenever
> free()s are added... So is risk of freeing
> that is still being used. Plus they will
> get a good workout at the upcoming Bakeathon.
> 
> Steve Dickson (19):
>   Removed resource leaks from junction/path.c
>   Removed resource leaks from nfs/exports.c
>   Removed a resource leak from nfs/mydaemon.c
>   Removed a resource leak from nfs/rpcmisc.c
>   Removed a resource leak from nfs/svc_socket.c
>   Removed bad frees from nfs/xcommon.c
>   Removed resource leaks from nfs/xlog.c
>   Removed resource leaks from nfsidmap/libnfsidmap.c
>   Removed resource leaks from nfsidmap/static.c
>   Removed a resource leak from nsm/file.c
>   Removed resource leaks from systemd/rpc-pipefs-generator.c
>   Removed resource leaks from blkmapd/device-discovery.c
>   Removed resource leaks from gssd/krb5_util.c
>   Removed a resource leak from mount/configfile.c
>   Removed a resource leak from mount/nfsmount.c
>   Removed a resource leak from mount/stropts.c
>   Removed resource leaks from mountd/cache.c
>   Removed a resource leak from mountd/fsloc.c
>   Removed a resource leak from nfsdcltrack/sqlite.c
> 
>  support/junction/path.c          |  6 +++++-
>  support/nfs/exports.c            |  2 ++
>  support/nfs/mydaemon.c           |  1 +
>  support/nfs/rpcmisc.c            |  1 +
>  support/nfs/svc_socket.c         |  1 +
>  support/nfs/xcommon.c            | 14 ++++++++++----
>  support/nfs/xlog.c               |  6 +++++-
>  support/nfsidmap/libnfsidmap.c   | 10 ++++++++--
>  support/nfsidmap/static.c        | 10 ++++++++++
>  support/nsm/file.c               |  1 +
>  systemd/rpc-pipefs-generator.c   | 10 ++++++++--
>  utils/blkmapd/device-discovery.c | 22 +++++++++++++++++++++-
>  utils/gssd/krb5_util.c           |  9 ++++++++-
>  utils/mount/configfile.c         |  2 +-
>  utils/mount/nfsmount.c           |  1 +
>  utils/mount/stropts.c            |  5 ++++-
>  utils/mountd/cache.c             |  5 +++--
>  utils/mountd/fsloc.c             |  1 +
>  utils/nfsdcltrack/sqlite.c       |  2 ++
>  19 files changed, 93 insertions(+), 16 deletions(-)
> 
Committed... 

steved.