| Message ID | 20140801164843.GB32749@fieldses.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 1 Aug 2014 12:48:43 -0400 "J. Bruce Fields" <bfields@fieldses.org> wrote: > On Tue, Jul 29, 2014 at 09:34:26PM -0400, Jeff Layton wrote: > > struct nfs4_stateowner { > > - struct list_head so_strhash; /* hash by op_name */ > > - struct list_head so_stateids; > > - struct nfs4_client * so_client; > > + struct list_head so_strhash; > > + struct list_head so_stateids; > > + struct nfs4_client *so_client; > > + const struct nfs4_stateowner_operations *so_ops; > > /* after increment in ENCODE_SEQID_OP_TAIL, represents the next > > * sequence id expected from the client: */ > > Uh, that could use updating--applying below. > > Anyway, the stateowner reference counting makes sense to me. > > --b. > > commit 84a46922ea90 > Author: J. Bruce Fields <bfields@redhat.com> > Date: Thu Jul 31 16:10:08 2014 -0400 > > nfsd4: fix out of date comment > > Signed-off-by: J. Bruce Fields <bfields@redhat.com> > > diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h > index 73a209dc352b..0b234500f104 100644 > --- a/fs/nfsd/state.h > +++ b/fs/nfsd/state.h > @@ -345,7 +345,7 @@ struct nfs4_stateowner { > struct list_head so_stateids; > struct nfs4_client *so_client; > const struct nfs4_stateowner_operations *so_ops; > - /* after increment in ENCODE_SEQID_OP_TAIL, represents the next > + /* after increment in nfsd4_bump_seqid, represents the next > * sequence id expected from the client: */ > atomic_t so_count; > u32 so_seqid; Ahh yeah, I meant to update that comment and never got around to it. Thanks! Acked-by: Jeff Layton <jlayton@primarydata.com> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h index 73a209dc352b..0b234500f104 100644 --- a/fs/nfsd/state.h +++ b/fs/nfsd/state.h @@ -345,7 +345,7 @@ struct nfs4_stateowner { struct list_head so_stateids; struct nfs4_client *so_client; const struct nfs4_stateowner_operations *so_ops; - /* after increment in ENCODE_SEQID_OP_TAIL, represents the next + /* after increment in nfsd4_bump_seqid, represents the next * sequence id expected from the client: */ atomic_t so_count; u32 so_seqid;