diff mbox

[2/2] net/sunrpc/auth.c: move NULL check in rpcauth_invalcred() before first dereference

Message ID 51828687.7040605@stud.fit.vutbr.cz (mailing list archive)
State New, archived
Headers show

Commit Message

Radmila Kompová May 2, 2013, 3:30 p.m. UTC 
Detected by cppcheck.

Signed-off-by: Kamil Dudka <kdudka@redhat.com>
---
 net/sunrpc/auth.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index ed2fdd2..cba5529 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -767,11 +767,12 @@  void
 rpcauth_invalcred(struct rpc_task *task)
 {
 	struct rpc_cred *cred = task->tk_rqstp->rq_cred;
+	if (!cred)
+		return;

 	dprintk("RPC: %5u invalidating %s cred %p\n",
 		task->tk_pid, cred->cr_auth->au_ops->au_name, cred);
-	if (cred)
-		clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags);
+	clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags);
 }

 int