diff mbox

[ndctl] completion: updates for file name completion

Message ID 20170329173616.7571-1-vishal.l.verma@intel.com (mailing list archive)
State Accepted
Commit e38bd36e5d0a
Headers show

Commit Message

Vishal Verma March 29, 2017, 5:36 p.m. UTC 
Add file name completion for the --input and --output arguments of
read-labels and the new write-labels commands.

Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 contrib/ndctl | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

Comments

Dan Williams March 29, 2017, 6:01 p.m. UTC | #1 
On Wed, Mar 29, 2017 at 10:36 AM, Vishal Verma <vishal.l.verma@intel.com> wrote:
> Add file name completion for the --input and --output arguments of
> read-labels and the new write-labels commands.
>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Thanks! Applied.
diff mbox

Patch

diff --git a/contrib/ndctl b/contrib/ndctl
index c97adcc..076423f 100755
--- a/contrib/ndctl
+++ b/contrib/ndctl
@@ -91,7 +91,7 @@  __ndctlcomp()
 
 	COMPREPLY=( $( compgen -W "$1" -- "$2" ) )
 	for cword in "${COMPREPLY[@]}"; do
-		if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace) ]]; then
+		if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output) ]]; then
 			COMPREPLY[$i]="${cword}="
 		else
 			COMPREPLY[$i]="${cword} "
@@ -132,6 +132,11 @@  __ndctl_get_dimms()
 	echo "$(ndctl list $opts | grep -E "^\s*\"dev\":" | cut -d\" -f4)"
 }
 
+__ndctl_file_comp()
+{
+	local cur="$1"
+	_filedir
+}
 __ndctl_comp_options()
 {
 	local cur=$1
@@ -171,6 +176,12 @@  __ndctl_comp_options()
 		--map)
 			opts="mem dev"
 			;;
+		--output)
+			;&
+		--input)
+			__ndctl_file_comp "${cur##*=}"
+			return
+			;;
 		*)
 			return
 			;;
@@ -215,6 +226,8 @@  __ndctl_comp_non_option_args()
 		;&
 	read-labels)
 		;&
+	write-labels)
+		;&
 	zero-labels)
 		opts="$(__ndctl_get_dimms -i) all"
 		;;