| Message ID | 1551415936-30174-1-git-send-email-srinath.mannam@broadcom.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add IPROC PCIe new features | expand |
Hi Lorenzo/Bjorn, Could you please help to review this patch series when you have time? I believe I have addressed all your review comments. Thanks, Srinath. On Fri, Mar 1, 2019 at 10:22 AM Srinath Mannam <srinath.mannam@broadcom.com> wrote: > > This patch set extends support of new IPROC PCIe host controller features > - Add CRS check using controller register status flags > - Add outbound window mapping configuration for 32-bit I/O region > > This patch set is based on Linux-5.0-rc2. > > Changes from v3: > - Addressed Lorenzo Pieralisi comments. > > Changes from v2: > - Based on Lorenzo Pieralisi comments, commit logs are expanded. > > Changes from v1: > - Addressed Bjorn Helgaas comments. > - Removed set order mode patch from patchset. > > Srinath Mannam (2): > PCI: iproc: Add CRS check in config read > PCI: iproc: Add outbound configuration for 32-bit I/O region > > drivers/pci/controller/pcie-iproc.c | 44 +++++++++++++++++++++++++++++++++---- > 1 file changed, 40 insertions(+), 4 deletions(-) > > -- > 2.7.4 >
On Wed, Mar 27, 2019 at 02:08:46PM +0530, Srinath Mannam wrote: > Hi Lorenzo/Bjorn, > > Could you please help to review this patch series when you have time? > I believe I have addressed all your review comments. I will shortly keeping in mind that you should really ask HW designers to get to grips with a proper design because there are ways too many HW quirks this driver has to fix-up, it has become an unmanageable collection of work arounds. Lorenzo > Thanks, > Srinath. > > On Fri, Mar 1, 2019 at 10:22 AM Srinath Mannam > <srinath.mannam@broadcom.com> wrote: > > > > This patch set extends support of new IPROC PCIe host controller features > > - Add CRS check using controller register status flags > > - Add outbound window mapping configuration for 32-bit I/O region > > > > This patch set is based on Linux-5.0-rc2. > > > > Changes from v3: > > - Addressed Lorenzo Pieralisi comments. > > > > Changes from v2: > > - Based on Lorenzo Pieralisi comments, commit logs are expanded. > > > > Changes from v1: > > - Addressed Bjorn Helgaas comments. > > - Removed set order mode patch from patchset. > > > > Srinath Mannam (2): > > PCI: iproc: Add CRS check in config read > > PCI: iproc: Add outbound configuration for 32-bit I/O region > > > > drivers/pci/controller/pcie-iproc.c | 44 +++++++++++++++++++++++++++++++++---- > > 1 file changed, 40 insertions(+), 4 deletions(-) > > > > -- > > 2.7.4 > >
Hi Lorenzo, Thanks for feedback, I will talk to our HW engineer. Regards, Srinath. On Wed, Mar 27, 2019 at 6:01 PM Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Wed, Mar 27, 2019 at 02:08:46PM +0530, Srinath Mannam wrote: > > Hi Lorenzo/Bjorn, > > > > Could you please help to review this patch series when you have time? > > I believe I have addressed all your review comments. > > I will shortly keeping in mind that you should really ask HW designers > to get to grips with a proper design because there are ways too many HW > quirks this driver has to fix-up, it has become an unmanageable > collection of work arounds. > > Lorenzo > > > Thanks, > > Srinath. > > > > On Fri, Mar 1, 2019 at 10:22 AM Srinath Mannam > > <srinath.mannam@broadcom.com> wrote: > > > > > > This patch set extends support of new IPROC PCIe host controller features > > > - Add CRS check using controller register status flags > > > - Add outbound window mapping configuration for 32-bit I/O region > > > > > > This patch set is based on Linux-5.0-rc2. > > > > > > Changes from v3: > > > - Addressed Lorenzo Pieralisi comments. > > > > > > Changes from v2: > > > - Based on Lorenzo Pieralisi comments, commit logs are expanded. > > > > > > Changes from v1: > > > - Addressed Bjorn Helgaas comments. > > > - Removed set order mode patch from patchset. > > > > > > Srinath Mannam (2): > > > PCI: iproc: Add CRS check in config read > > > PCI: iproc: Add outbound configuration for 32-bit I/O region > > > > > > drivers/pci/controller/pcie-iproc.c | 44 +++++++++++++++++++++++++++++++++---- > > > 1 file changed, 40 insertions(+), 4 deletions(-) > > > > > > -- > > > 2.7.4 > > >
On Fri, Mar 01, 2019 at 10:22:14AM +0530, Srinath Mannam wrote: > This patch set extends support of new IPROC PCIe host controller features > - Add CRS check using controller register status flags > - Add outbound window mapping configuration for 32-bit I/O region > > This patch set is based on Linux-5.0-rc2. > > Changes from v3: > - Addressed Lorenzo Pieralisi comments. > > Changes from v2: > - Based on Lorenzo Pieralisi comments, commit logs are expanded. > > Changes from v1: > - Addressed Bjorn Helgaas comments. > - Removed set order mode patch from patchset. > > Srinath Mannam (2): > PCI: iproc: Add CRS check in config read > PCI: iproc: Add outbound configuration for 32-bit I/O region > > drivers/pci/controller/pcie-iproc.c | 44 +++++++++++++++++++++++++++++++++---- I need Ray a/o Scott ACK to merge this series, thanks. Lorenzo
On 2019-03-29 9:51 a.m., Lorenzo Pieralisi wrote: > On Fri, Mar 01, 2019 at 10:22:14AM +0530, Srinath Mannam wrote: >> This patch set extends support of new IPROC PCIe host controller features >> - Add CRS check using controller register status flags >> - Add outbound window mapping configuration for 32-bit I/O region >> >> This patch set is based on Linux-5.0-rc2. >> >> Changes from v3: >> - Addressed Lorenzo Pieralisi comments. >> >> Changes from v2: >> - Based on Lorenzo Pieralisi comments, commit logs are expanded. >> >> Changes from v1: >> - Addressed Bjorn Helgaas comments. >> - Removed set order mode patch from patchset. >> >> Srinath Mannam (2): >> PCI: iproc: Add CRS check in config read >> PCI: iproc: Add outbound configuration for 32-bit I/O region >> >> drivers/pci/controller/pcie-iproc.c | 44 +++++++++++++++++++++++++++++++++---- > I need Ray a/o Scott ACK to merge this series, thanks. Unfortunately we need this due to hardware design (which we continue to inform the silicon team to provide a proper design). Acked-by: Scott Branden <scott.branden@broadcom.com> > > Lorenzo