mbox series

[v2,0/2] PCI: endpoint: Fix core_init_notifier feature

Message ID 1630473361-27198-1-git-send-email-hayashi.kunihiko@socionext.com (mailing list archive)
Headers show
Series PCI: endpoint: Fix core_init_notifier feature | expand

Message

Kunihiko Hayashi Sept. 1, 2021, 5:15 a.m. UTC
This series has two fixes for core_init_notifier feature.

Fix the bug that the driver can't register its notifier function
if core_init_notifier == true and linkup_notifier == false.

If enabling the controller is delayed due to core_init_notifier, 
accesses to the controller register should be avoided rather than
enabling the controller.

Changes since v1:
- Add Acked-by and Reviewed-by lines

Kunihiko Hayashi (2):
  PCI: endpoint: pci-epf-test: register notifier if only
    core_init_notifier is enabled
  PCI: designware-ep: Fix the access to DBI/iATU registers before
    enabling controller

 drivers/pci/controller/dwc/pcie-designware-ep.c | 81 +++++++++++++------------
 drivers/pci/endpoint/functions/pci-epf-test.c   |  2 +-
 2 files changed, 42 insertions(+), 41 deletions(-)

Comments

Kunihiko Hayashi Sept. 16, 2021, 11:30 a.m. UTC | #1
Gentle ping, are there any comments about this series?

Thank you,

On 2021/09/01 14:15, Kunihiko Hayashi wrote:
> This series has two fixes for core_init_notifier feature.
> 
> Fix the bug that the driver can't register its notifier function
> if core_init_notifier == true and linkup_notifier == false.
> 
> If enabling the controller is delayed due to core_init_notifier,
> accesses to the controller register should be avoided rather than
> enabling the controller.
> 
> Changes since v1:
> - Add Acked-by and Reviewed-by lines
> 
> Kunihiko Hayashi (2):
>    PCI: endpoint: pci-epf-test: register notifier if only
>      core_init_notifier is enabled
>    PCI: designware-ep: Fix the access to DBI/iATU registers before
>      enabling controller
> 
>   drivers/pci/controller/dwc/pcie-designware-ep.c | 81 +++++++++++++------------
>   drivers/pci/endpoint/functions/pci-epf-test.c   |  2 +-
>   2 files changed, 42 insertions(+), 41 deletions(-)
>
Lorenzo Pieralisi Dec. 1, 2021, 3:04 p.m. UTC | #2
On Thu, Sep 16, 2021 at 08:30:35PM +0900, Kunihiko Hayashi wrote:
> Gentle ping, are there any comments about this series?

Kishon,

can you have a look please ?

Thanks,
Lorenzo

> Thank you,
> 
> On 2021/09/01 14:15, Kunihiko Hayashi wrote:
> > This series has two fixes for core_init_notifier feature.
> > 
> > Fix the bug that the driver can't register its notifier function
> > if core_init_notifier == true and linkup_notifier == false.
> > 
> > If enabling the controller is delayed due to core_init_notifier,
> > accesses to the controller register should be avoided rather than
> > enabling the controller.
> > 
> > Changes since v1:
> > - Add Acked-by and Reviewed-by lines
> > 
> > Kunihiko Hayashi (2):
> >    PCI: endpoint: pci-epf-test: register notifier if only
> >      core_init_notifier is enabled
> >    PCI: designware-ep: Fix the access to DBI/iATU registers before
> >      enabling controller
> > 
> >   drivers/pci/controller/dwc/pcie-designware-ep.c | 81 +++++++++++++------------
> >   drivers/pci/endpoint/functions/pci-epf-test.c   |  2 +-
> >   2 files changed, 42 insertions(+), 41 deletions(-)
> > 
> 
> -- 
> ---
> Best Regards
> Kunihiko Hayashi