mbox series

[0/3] Fixes for "PCIE support for i.MX8MQ"

Message ID 20181216230916.22982-1-andrew.smirnov@gmail.com (mailing list archive)
Headers show
Series Fixes for "PCIE support for i.MX8MQ" | expand

Message

Andrey Smirnov Dec. 16, 2018, 11:09 p.m. UTC
Lorenzo:

These are patches fixing things pointed out by Bjorn in [1] and [2] as
well as something I noticed while giving pci/next branch a try (#endif
placement). Hopefully this is at least somewhat helpful.

Thanks,
Andrey Smirnov

[1] lkml.kernel.org/r/20181214203828.GD20725@google.com
[2] lkml.kernel.org/r/20181214203042.GC20725@google.com

Andrey Smirnov (3):
  PCI: imx6: Fixup Kconfig and #endif placement
  PCI: imx6: Invert checks in imx6_pcie_reset_phy() and
    imx6_setup_phy_mpll()
  PCI: imx6: Make fallthrough comments more consistent

 drivers/pci/controller/dwc/Kconfig    |  4 ++--
 drivers/pci/controller/dwc/pci-imx6.c | 29 ++++++++++++++++++---------
 2 files changed, 21 insertions(+), 12 deletions(-)

Comments

Lorenzo Pieralisi Dec. 17, 2018, 11 a.m. UTC | #1
On Sun, Dec 16, 2018 at 03:09:13PM -0800, Andrey Smirnov wrote:
> Lorenzo:
> 
> These are patches fixing things pointed out by Bjorn in [1] and [2] as
> well as something I noticed while giving pci/next branch a try (#endif
> placement). Hopefully this is at least somewhat helpful.
> 
> Thanks,
> Andrey Smirnov
> 
> [1] lkml.kernel.org/r/20181214203828.GD20725@google.com
> [2] lkml.kernel.org/r/20181214203042.GC20725@google.com
> 
> Andrey Smirnov (3):
>   PCI: imx6: Fixup Kconfig and #endif placement
>   PCI: imx6: Invert checks in imx6_pcie_reset_phy() and
>     imx6_setup_phy_mpll()
>   PCI: imx6: Make fallthrough comments more consistent
> 
>  drivers/pci/controller/dwc/Kconfig    |  4 ++--
>  drivers/pci/controller/dwc/pci-imx6.c | 29 ++++++++++++++++++---------
>  2 files changed, 21 insertions(+), 12 deletions(-)

Andrey,

please follow-up Lucas' remarks and submit a self-consistent patchset
that I can apply on top of my pci/dwc branch (where I removed your
previously queued patches).

Thanks,
Lorenzo
Andrey Smirnov Dec. 17, 2018, 5:18 p.m. UTC | #2
On Mon, Dec 17, 2018 at 3:01 AM Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Sun, Dec 16, 2018 at 03:09:13PM -0800, Andrey Smirnov wrote:
> > Lorenzo:
> >
> > These are patches fixing things pointed out by Bjorn in [1] and [2] as
> > well as something I noticed while giving pci/next branch a try (#endif
> > placement). Hopefully this is at least somewhat helpful.
> >
> > Thanks,
> > Andrey Smirnov
> >
> > [1] lkml.kernel.org/r/20181214203828.GD20725@google.com
> > [2] lkml.kernel.org/r/20181214203042.GC20725@google.com
> >
> > Andrey Smirnov (3):
> >   PCI: imx6: Fixup Kconfig and #endif placement
> >   PCI: imx6: Invert checks in imx6_pcie_reset_phy() and
> >     imx6_setup_phy_mpll()
> >   PCI: imx6: Make fallthrough comments more consistent
> >
> >  drivers/pci/controller/dwc/Kconfig    |  4 ++--
> >  drivers/pci/controller/dwc/pci-imx6.c | 29 ++++++++++++++++++---------
> >  2 files changed, 21 insertions(+), 12 deletions(-)
>
> Andrey,
>
> please follow-up Lucas' remarks and submit a self-consistent patchset
> that I can apply on top of my pci/dwc branch (where I removed your
> previously queued patches).
>

Sure, will do.

Thanks,
Andrey Smirnov