[0/5] DesignWare PCI improvements

Message

Andrey Smirnov Feb. 19, 2019, 8:02 p.m. UTC

Everyone:

This is the series is a spin-off from [imx6-dwc] containing only small
improvements that I made while reading the code and researching commit
history of pcie-designware*.c. All changes are optional, so
commits that don't seem like an improvement can be easily
dropped. Hopefully each patch is self-explanatory.

I tested this series on i.MX6Q, i.MX7D and i.MX8MQ.

Feedback is welcome!

Thanks,
Andrey Smirnov

[imx6-dwc] https://lore.kernel.org/lkml/[e-mail]

Andrey Smirnov (5):
  PCI: dwc: Make use of IS_ALIGNED()
  PCI: dwc: Share code for dw_pcie_rd/wr_other_conf()
  PCI: dwc: Make use of BIT() in constant definitions
  PCI: dwc: Make use of GENMASK/FIELD_PREP
  PCI: dwc: Remove superfluous shifting in definitions

 .../pci/controller/dwc/pcie-designware-host.c | 61 +++++++------------
 drivers/pci/controller/dwc/pcie-designware.c  |  6 +-
 drivers/pci/controller/dwc/pcie-designware.h  | 57 +++++++++--------
 3 files changed, 56 insertions(+), 68 deletions(-)

Comments

Lorenzo Pieralisi Feb. 20, 2019, 10:26 a.m. UTC | #1

On Tue, Feb 19, 2019 at 12:02:37PM -0800, Andrey Smirnov wrote:
> Everyone:
> 
> This is the series is a spin-off from [imx6-dwc] containing only small
> improvements that I made while reading the code and researching commit
> history of pcie-designware*.c. All changes are optional, so
> commits that don't seem like an improvement can be easily
> dropped. Hopefully each patch is self-explanatory.
> 
> I tested this series on i.MX6Q, i.MX7D and i.MX8MQ.
> 
> Feedback is welcome!
> 
> Thanks,
> Andrey Smirnov
> 
> [imx6-dwc] https://lore.kernel.org/lkml/[e-mail]
> 
> Andrey Smirnov (5):
>   PCI: dwc: Make use of IS_ALIGNED()
>   PCI: dwc: Share code for dw_pcie_rd/wr_other_conf()
>   PCI: dwc: Make use of BIT() in constant definitions
>   PCI: dwc: Make use of GENMASK/FIELD_PREP
>   PCI: dwc: Remove superfluous shifting in definitions
> 
>  .../pci/controller/dwc/pcie-designware-host.c | 61 +++++++------------
>  drivers/pci/controller/dwc/pcie-designware.c  |  6 +-
>  drivers/pci/controller/dwc/pcie-designware.h  | 57 +++++++++--------
>  3 files changed, 56 insertions(+), 68 deletions(-)
 

Applied to pci/dwc for v5.1, thanks.

Lorenzo