| Message ID | 20210531221057.3406958-1-punitagrawal@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: of: Improvements to handle 64-bit attribute for non-prefetchable ranges | expand |
Hi Punit, On 5/31/21 11:10 PM, Punit Agrawal wrote: > Hi, > > Here's an updated version of changes to improve handling of the 64-bit > attribute on non-prefetchable host bridge ranges. Previous version can > be found at [0]. > > The series addresses Rob and Bjorn's comments on the previous version > and updates the checks for 32-bit non-prefetchable window size to only > apply to non 64-bit ranges. Many thanks for the series. I've tested it on my rockpro64, and the NVME works as expected: Tested-by: Alexandru Elisei <alexandru.elisei@arm.com> Thanks, Alex > > Thanks, > Punit > > Changes: > v2: > * Check ranges PCI / bus addresses rather than CPU addresses > * (new) Restrict 32-bit size warnings on ranges that don't have the 64-bit attribute set > * Refactor the 32-bit size warning to the range parsing loop. This > change also prints the warnings right after the window mappings are > logged. > > > [0] https://lore.kernel.org/linux-arm-kernel/20210527150541.3130505-1-punitagrawal@gmail.com/ > > Punit Agrawal (4): > PCI: of: Override 64-bit flag for non-prefetchable memory below 4GB > PCI: of: Relax the condition for warning about non-prefetchable memory > aperture size > PCI: of: Refactor the check for non-prefetchable 32-bit window > arm64: dts: rockchip: Update PCI host bridge window to 32-bit address > memory > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- > drivers/pci/of.c | 17 ++++++++++++----- > 2 files changed, 13 insertions(+), 6 deletions(-) >
Hi Alex, Alexandru Elisei <alexandru.elisei@arm.com> writes: > Hi Punit, > > On 5/31/21 11:10 PM, Punit Agrawal wrote: >> Hi, >> >> Here's an updated version of changes to improve handling of the 64-bit >> attribute on non-prefetchable host bridge ranges. Previous version can >> be found at [0]. >> >> The series addresses Rob and Bjorn's comments on the previous version >> and updates the checks for 32-bit non-prefetchable window size to only >> apply to non 64-bit ranges. > > Many thanks for the series. I've tested it on my rockpro64, and the NVME works as > expected: > > Tested-by: Alexandru Elisei <alexandru.elisei@arm.com> Thanks for taking the patches for a spin. Punit [...]
Hi, Here's an updated version of changes to improve handling of the 64-bit attribute on non-prefetchable host bridge ranges. Previous version can be found at [0]. The series addresses Rob and Bjorn's comments on the previous version and updates the checks for 32-bit non-prefetchable window size to only apply to non 64-bit ranges. Thanks, Punit Changes: v2: * Check ranges PCI / bus addresses rather than CPU addresses * (new) Restrict 32-bit size warnings on ranges that don't have the 64-bit attribute set * Refactor the 32-bit size warning to the range parsing loop. This change also prints the warnings right after the window mappings are logged. [0] https://lore.kernel.org/linux-arm-kernel/20210527150541.3130505-1-punitagrawal@gmail.com/ Punit Agrawal (4): PCI: of: Override 64-bit flag for non-prefetchable memory below 4GB PCI: of: Relax the condition for warning about non-prefetchable memory aperture size PCI: of: Refactor the check for non-prefetchable 32-bit window arm64: dts: rockchip: Update PCI host bridge window to 32-bit address memory arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- drivers/pci/of.c | 17 ++++++++++++----- 2 files changed, 13 insertions(+), 6 deletions(-)