| Message ID | 20210722111903.432-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: Make use of PCI_DEVICE_XXX() helper function | expand |
On Thu, Jul 22, 2021 at 07:19:01PM +0800, Cai Huoqing wrote: > Could make use of PCI_DEVICE_XXX() helper function > > Cai Huoqing (2): > PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function > PCI: vmd: Make use of PCI_DEVICE_DATA() helper function > > drivers/pci/controller/vmd.c | 38 +++++++++++++++---------------- > drivers/pci/hotplug/cpqphp_core.c | 13 ++--------- > drivers/pci/search.c | 14 ++---------- > include/linux/pci_ids.h | 2 ++ > 4 files changed, 25 insertions(+), 42 deletions(-) When you fix the problem below, also: s/Make use of/Use/ Update commit log to say what the patch does. See https://chris.beams.io/posts/git-commit/ for hints. Add period at end of sentences. I don't see exactly what's wrong, but this series doesn't apply cleanly. I'm using b4 to fetch the series. b4 is from https://git.kernel.org/pub/scm/utils/b4/b4.git 11:47:04 ~/linux (main)$ git checkout -b wip/cai v5.14-rc1 Switched to a new branch 'wip/cai' 11:47:17 ~/linux (wip/cai)$ b4 am -om/ 20210722111903.432-1-caihuoqing@baidu.com Looking up https://lore.kernel.org/r/20210722111903.432-1-caihuoqing%40baidu.com Grabbing thread from lore.kernel.org/linux-pci Analyzing 3 messages in the thread --- Writing m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.mbx [PATCH 1/2] PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() helper function --- Total patches: 2 --- Cover: m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.cover Link: https://lore.kernel.org/r/20210722111903.432-1-caihuoqing@baidu.com Base: not found (applies clean to current tree) git am m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.mbx 11:47:45 ~/linux (wip/cai)$ git am m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.mbx Applying: PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function error: patch failed: drivers/pci/hotplug/cpqphp_core.c:1357 error: drivers/pci/hotplug/cpqphp_core.c: patch does not apply error: patch failed: drivers/pci/search.c:303 error: drivers/pci/search.c: patch does not apply Patch failed at 0001 PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Hello I get it and will send patch PATCH again. THX -----Original Message----- From: Bjorn Helgaas <helgaas@kernel.org> Sent: 2021年7月23日 0:52 To: Cai,Huoqing <caihuoqing@baidu.com> Cc: bhelgaas@google.com; jonathan.derrick@intel.com; kw@linux.com; onathan.derrick@intel.com; lorenzo.pieralisi@arm.com; robh@kernel.org; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] PCI: Make use of PCI_DEVICE_XXX() helper function On Thu, Jul 22, 2021 at 07:19:01PM +0800, Cai Huoqing wrote: > Could make use of PCI_DEVICE_XXX() helper function > > Cai Huoqing (2): > PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function > PCI: vmd: Make use of PCI_DEVICE_DATA() helper function > > drivers/pci/controller/vmd.c | 38 +++++++++++++++---------------- > drivers/pci/hotplug/cpqphp_core.c | 13 ++--------- > drivers/pci/search.c | 14 ++---------- > include/linux/pci_ids.h | 2 ++ > 4 files changed, 25 insertions(+), 42 deletions(-) When you fix the problem below, also: s/Make use of/Use/ Update commit log to say what the patch does. See https://chris.beams.io/posts/git-commit/ for hints. Add period at end of sentences. I don't see exactly what's wrong, but this series doesn't apply cleanly. I'm using b4 to fetch the series. b4 is from https://git.kernel.org/pub/scm/utils/b4/b4.git 11:47:04 ~/linux (main)$ git checkout -b wip/cai v5.14-rc1 Switched to a new branch 'wip/cai' 11:47:17 ~/linux (wip/cai)$ b4 am -om/ 20210722111903.432-1-caihuoqing@baidu.com Looking up https://lore.kernel.org/r/20210722111903.432-1-caihuoqing%40baidu.com Grabbing thread from lore.kernel.org/linux-pci Analyzing 3 messages in the thread --- Writing m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.mbx [PATCH 1/2] PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() helper function --- Total patches: 2 --- Cover: m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.cover Link: https://lore.kernel.org/r/20210722111903.432-1-caihuoqing@baidu.com Base: not found (applies clean to current tree) git am m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.mbx 11:47:45 ~/linux (wip/cai)$ git am m/20210722_caihuoqing_pci_make_use_of_pci_device_xxx_helper_function.mbx Applying: PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function error: patch failed: drivers/pci/hotplug/cpqphp_core.c:1357 error: drivers/pci/hotplug/cpqphp_core.c: patch does not apply error: patch failed: drivers/pci/search.c:303 error: drivers/pci/search.c: patch does not apply Patch failed at 0001 PCI: Make use of PCI_DEVICE_SUB/_CLASS() helper function hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".