| Series |
PCI/MSI, x86: Cure a couple of inconsistencies
|
expand
-
[V2,00/19] PCI/MSI, x86: Cure a couple of inconsistencies
-
[V2,01/19] PCI/MSI: Enable and mask MSI-X early
-
[V2,02/19] PCI/MSI: Mask all unused MSI-X entries
-
[V2,03/19] PCI/MSI: Enforce that MSI-X table entry is masked for update
-
[V2,04/19] PCI/MSI: Enforce MSI[X] entry updates to be visible
-
[V2,05/19] PCI/MSI: Do not set invalid bits in MSI mask
-
[V2,06/19] PCI/MSI: Correct misleading comments
-
[V2,07/19] PCI/MSI: Use msi_mask_irq() in pci_msi_shutdown()
-
[V2,08/19] PCI/MSI: Protect msi_desc::masked for multi-MSI
-
[V2,09/19] genirq: Provide IRQCHIP_AFFINITY_PRE_STARTUP
-
[V2,10/19] x86/ioapic: Force affinity setup before startup
-
[V2,11/19] x86/msi: Force affinity setup before startup
-
[V2,12/19] s390/pci: Do not mask MSI[-X] entries on teardown
-
[V2,13/19] PCI/MSI: Simplify msi_verify_entries()
-
[V2,14/19] PCI/MSI: Rename msi_desc::masked
-
[V2,15/19] PCI/MSI: Consolidate error handling in msi_capability_init()
-
[V2,16/19] PCI/MSI: Deobfuscate virtual MSI-X
-
[V2,17/19] PCI/MSI: Cleanup msi_mask()
-
[V2,18/19] PCI/MSI: Provide a new set of mask and unmask functions
-
[V2,19/19] PCI/MSI: Use new mask/unmask functions
|
A recent discussion about the PCI/MSI management for virtio unearthed a violation of the MSI-X specification vs. writing the MSI-X message: under certain circumstances the entry is written without being masked. While looking at that and the related violation of the x86 non-remapped interrupt affinity mechanism a few other issues were discovered by inspection. The following series addresses these. Note this does not fix the virtio issue, but while staring at the above problems I came up with a plan to address this. I'm still trying to convince myself that I can get away without sprinkling locking all over the place, so don't hold your breath that this will materialize tomorrow. The series is also available from git: git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git irq/msi V1 can be found here: https://lore.kernel.org/r/20210721191126.274946280@linutronix.de Changes vs. V1: - Identified and addressed more inconsistencies, especially the lack of serialization for multi-MSI masking - Removed the extra vector masking in S390 - Addressed review comments and picked up tags where applicable - Clean up of the naming of msi_desc::masked as discussed in the V1 thread - Consolidation of the mask/unmask functions Thanks, tglx --- arch/s390/pci/pci_irq.c | 4 arch/x86/kernel/apic/io_apic.c | 6 arch/x86/kernel/apic/msi.c | 11 + arch/x86/kernel/hpet.c | 2 drivers/base/core.c | 1 drivers/pci/msi.c | 274 ++++++++++++++++++++++------------------- include/linux/device.h | 1 include/linux/irq.h | 2 include/linux/msi.h | 10 - kernel/irq/chip.c | 5 10 files changed, 178 insertions(+), 138 deletions(-)