| Message ID | 20211104180130.3825416-1-maz@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: MSI: Deal with devices lying about their masking capability | expand |
On Thu, Nov 04 2021 at 18:01, Marc Zyngier wrote: > Rui reported[1] that his Nvidia ION system stopped working with 5.15, > with the AHCI device failing to get any MSI. A rapid investigation > revealed that although the device doesn't advertise MSI masking, it > actually needs it. Quality hardware indeed. > > Anyway, the couple of patches below are an attempt at dealing with the > issue in a more or less generic way. > > [1] https://lore.kernel.org/r/CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com > > Marc Zyngier (2): > PCI: MSI: Deal with devices lying about their MSI mask capability > PCI: Add MSI masking quirk for Nvidia ION AHCI > > drivers/pci/msi.c | 3 +++ > drivers/pci/quirks.c | 6 ++++++ > include/linux/pci.h | 2 ++ > 3 files changed, 11 insertions(+) Groan. Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Hi, Thomas, On Fri, 5 Nov 2021 at 13:14, Thomas Gleixner <tglx@linutronix.de> wrote: > > On Thu, Nov 04 2021 at 18:01, Marc Zyngier wrote: > > Rui reported[1] that his Nvidia ION system stopped working with 5.15, > > with the AHCI device failing to get any MSI. A rapid investigation > > revealed that although the device doesn't advertise MSI masking, it > > actually needs it. Quality hardware indeed. > > > > Anyway, the couple of patches below are an attempt at dealing with the > > issue in a more or less generic way. > > > > [1] https://lore.kernel.org/r/CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com > > > > Marc Zyngier (2): > > PCI: MSI: Deal with devices lying about their MSI mask capability > > PCI: Add MSI masking quirk for Nvidia ION AHCI > > > > drivers/pci/msi.c | 3 +++ > > drivers/pci/quirks.c | 6 ++++++ > > include/linux/pci.h | 2 ++ > > 3 files changed, 11 insertions(+) > > Groan. > > Reviewed-by: Thomas Gleixner <tglx@linutronix.de> Just a reminder, to make sure this doesn't fall through the cracks. It's already in 5.16, but needs to be backported to 5.15. I'm not seeing it in Greg's 5.15 stable queue yet. Thanks, Rui
On Tue, Nov 16, 2021 at 10:21:18AM +0000, Rui Salvaterra wrote: > Hi, Thomas, > > On Fri, 5 Nov 2021 at 13:14, Thomas Gleixner <tglx@linutronix.de> wrote: > > > > On Thu, Nov 04 2021 at 18:01, Marc Zyngier wrote: > > > Rui reported[1] that his Nvidia ION system stopped working with 5.15, > > > with the AHCI device failing to get any MSI. A rapid investigation > > > revealed that although the device doesn't advertise MSI masking, it > > > actually needs it. Quality hardware indeed. > > > > > > Anyway, the couple of patches below are an attempt at dealing with the > > > issue in a more or less generic way. > > > > > > [1] https://lore.kernel.org/r/CALjTZvbzYfBuLB+H=fj2J+9=DxjQ2Uqcy0if_PvmJ-nU-qEgkg@mail.gmail.com > > > > > > Marc Zyngier (2): > > > PCI: MSI: Deal with devices lying about their MSI mask capability > > > PCI: Add MSI masking quirk for Nvidia ION AHCI > > > > > > drivers/pci/msi.c | 3 +++ > > > drivers/pci/quirks.c | 6 ++++++ > > > include/linux/pci.h | 2 ++ > > > 3 files changed, 11 insertions(+) > > > > Groan. > > > > Reviewed-by: Thomas Gleixner <tglx@linutronix.de> > > Just a reminder, to make sure this doesn't fall through the cracks. > It's already in 5.16, but needs to be backported to 5.15. I'm not > seeing it in Greg's 5.15 stable queue yet. What is the git commit ids of these changes in Linus's tree? thanks, greg k-h
Hi, Greg, On Tue, 16 Nov 2021 at 10:39, Greg KH <gregkh@linuxfoundation.org> wrote: > > What is the git commit ids of these changes in Linus's tree? 2226667a145d ("PCI/MSI: Deal with devices lying about their MSI mask capability") f21082fb20db ("PCI: Add MSI masking quirk for Nvidia ION AHCI") Thanks, Rui
On Tue, Nov 16, 2021 at 10:47:23AM +0000, Rui Salvaterra wrote: > Hi, Greg, > > On Tue, 16 Nov 2021 at 10:39, Greg KH <gregkh@linuxfoundation.org> wrote: > > > > What is the git commit ids of these changes in Linus's tree? > > 2226667a145d ("PCI/MSI: Deal with devices lying about their MSI mask > capability") > f21082fb20db ("PCI: Add MSI masking quirk for Nvidia ION AHCI") Thanks, I'll queue them up in the next round of releases after the current ones are out. greg k-h
On Tue, Nov 16, 2021 at 11:56:32AM +0100, Greg KH wrote: > On Tue, Nov 16, 2021 at 10:47:23AM +0000, Rui Salvaterra wrote: > > Hi, Greg, > > > > On Tue, 16 Nov 2021 at 10:39, Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > What is the git commit ids of these changes in Linus's tree? > > > > 2226667a145d ("PCI/MSI: Deal with devices lying about their MSI mask > > capability") > > f21082fb20db ("PCI: Add MSI masking quirk for Nvidia ION AHCI") > > Thanks, I'll queue them up in the next round of releases after the > current ones are out. Now queued up. greg k-h