mbox series

[0/5] arm: ioremap: Remove pci_ioremap_io() and mvebu_pci_host_probe()

Message ID 20211124154116.916-1-pali@kernel.org (mailing list archive)
Headers show
Series arm: ioremap: Remove pci_ioremap_io() and mvebu_pci_host_probe() | expand

Message

Pali Rohár Nov. 24, 2021, 3:41 p.m. UTC
This patch series removes ARM specific functions pci_ioremap_io() and
mvebu_pci_host_probe() functions.

pci_ioremap_io() is replaced by standard PCI core function pci_remap_iospace()
and mvebu_pci_host_probe() by standard PCI core function pci_host_probe().

ARM needs custom implementation of pci_remap_iospace() because of
pci_ioremap_set_mem_type() hook used by Marvell Armada 375, 38x and 39x
platforms due to HW errata.

Patch series was compile-tested for all affected platforms and runtime
tested on Armada 385 with pci-mvebu.c driver.

Pali Rohár (5):
  arm: ioremap: Implement standard PCI function pci_remap_iospace()
  PCI: mvebu: Replace pci_ioremap_io() usage by devm_pci_remap_iospace()
  PCI: mvebu: Remove custom mvebu_pci_host_probe() function
  arm: ioremap: Replace pci_ioremap_io() usage by pci_remap_iospace()
  arm: ioremap: Remove unused ARM-specific function pci_ioremap_io()

 arch/arm/include/asm/io.h          |  5 ++-
 arch/arm/mach-dove/pcie.c          |  9 ++---
 arch/arm/mach-iop32x/pci.c         |  5 ++-
 arch/arm/mach-mv78xx0/pcie.c       |  5 ++-
 arch/arm/mach-orion5x/pci.c        | 10 ++++--
 arch/arm/mm/ioremap.c              | 16 +++++----
 drivers/pci/controller/pci-mvebu.c | 54 +++---------------------------
 drivers/pcmcia/at91_cf.c           |  6 +++-
 8 files changed, 45 insertions(+), 65 deletions(-)

Comments

Lorenzo Pieralisi Nov. 30, 2021, 11:11 a.m. UTC | #1
On Wed, 24 Nov 2021 16:41:11 +0100, Pali Rohár wrote:
> This patch series removes ARM specific functions pci_ioremap_io() and
> mvebu_pci_host_probe() functions.
> 
> pci_ioremap_io() is replaced by standard PCI core function pci_remap_iospace()
> and mvebu_pci_host_probe() by standard PCI core function pci_host_probe().
> 
> ARM needs custom implementation of pci_remap_iospace() because of
> pci_ioremap_set_mem_type() hook used by Marvell Armada 375, 38x and 39x
> platforms due to HW errata.
> 
> [...]

Applied to pci/mvebu, thanks!

[1/5] arm: ioremap: Implement standard PCI function pci_remap_iospace()
      https://git.kernel.org/lpieralisi/pci/c/bc02973a06
[2/5] PCI: mvebu: Replace pci_ioremap_io() usage by devm_pci_remap_iospace()
      https://git.kernel.org/lpieralisi/pci/c/c1aa4b55aa
[3/5] PCI: mvebu: Remove custom mvebu_pci_host_probe() function
      https://git.kernel.org/lpieralisi/pci/c/de58d49470
[4/5] arm: ioremap: Replace pci_ioremap_io() usage by pci_remap_iospace()
      https://git.kernel.org/lpieralisi/pci/c/9c8facde92
[5/5] arm: ioremap: Remove unused ARM-specific function pci_ioremap_io()
      https://git.kernel.org/lpieralisi/pci/c/ea76d27fb3

Thanks,
Lorenzo
Bjorn Helgaas Dec. 1, 2021, 5:11 p.m. UTC | #2
On Tue, Nov 30, 2021 at 11:11:43AM +0000, Lorenzo Pieralisi wrote:
> On Wed, 24 Nov 2021 16:41:11 +0100, Pali Rohár wrote:
> > This patch series removes ARM specific functions pci_ioremap_io() and
> > mvebu_pci_host_probe() functions.
> > 
> > pci_ioremap_io() is replaced by standard PCI core function pci_remap_iospace()
> > and mvebu_pci_host_probe() by standard PCI core function pci_host_probe().
> > 
> > ARM needs custom implementation of pci_remap_iospace() because of
> > pci_ioremap_set_mem_type() hook used by Marvell Armada 375, 38x and 39x
> > platforms due to HW errata.
> > 
> > [...]
> 
> Applied to pci/mvebu, thanks!
> 
> [1/5] arm: ioremap: Implement standard PCI function pci_remap_iospace()
>       https://git.kernel.org/lpieralisi/pci/c/bc02973a06
> [2/5] PCI: mvebu: Replace pci_ioremap_io() usage by devm_pci_remap_iospace()
>       https://git.kernel.org/lpieralisi/pci/c/c1aa4b55aa
> [3/5] PCI: mvebu: Remove custom mvebu_pci_host_probe() function
>       https://git.kernel.org/lpieralisi/pci/c/de58d49470
> [4/5] arm: ioremap: Replace pci_ioremap_io() usage by pci_remap_iospace()
>       https://git.kernel.org/lpieralisi/pci/c/9c8facde92
> [5/5] arm: ioremap: Remove unused ARM-specific function pci_ioremap_io()
>       https://git.kernel.org/lpieralisi/pci/c/ea76d27fb3

Beautiful.  I love getting rid of mvebu_pci_host_probe(), thank you!

If there's any occasion to update this branch, typos in the commit
logs:

[3/5]: s/functionn/function/
[4/5]: s/arm march code/ARM mach code/