mbox series

[v15,0/7] pci-epf-vntb clean up

Message ID 20221101165709.983416-1-Frank.Li@nxp.com (mailing list archive)
Headers show
Series pci-epf-vntb clean up | expand

Message

Frank Li Nov. 1, 2022, 4:57 p.m. UTC
continue patch series https://www.spinics.net/lists/linux-pci/msg130372.html
https://www.spinics.net/lists/linux-pci/msg130924.html

Lorenzo suggest create new series. Version number continue from old one

Change from v14-v15
  Fixed according to Manivannan Sadhasivam's comments, except endian
problem. Endian problem is out of this patch series scope.
  kernel test robot report sparse build warning problem already fixed
at patch 6 and 7.

Change from v13-v14
  split spare warning fix to two patch
  remove local variable reorder

Frank Li (7):
  PCI: endpoint: pci-epf-vntb: Clean up kernel_doc warning
  PCI: endpoint: pci-epf-vntb: Fix indentation of the struct
    epf_ntb_ctrl
  PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr at err
    path
  PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy
  PCI: endpoint: pci-epf-vntb: replace hardcode 4 with sizeof(u32)
  PCI: endpoint: pci-epf-vntb: fix sparse build warning at epf_db
  PCI: endpoint: pci-epf-vntb: fix sparse build warning at ntb->reg

 drivers/pci/endpoint/functions/pci-epf-vntb.c | 149 ++++++++++--------
 1 file changed, 85 insertions(+), 64 deletions(-)

Comments

Bjorn Helgaas Nov. 1, 2022, 5:20 p.m. UTC | #1
On Tue, Nov 01, 2022 at 12:57:02PM -0400, Frank Li wrote:
> continue patch series https://www.spinics.net/lists/linux-pci/msg130372.html
> https://www.spinics.net/lists/linux-pci/msg130924.html
> 
> Lorenzo suggest create new series. Version number continue from old one
> 
> Change from v14-v15
>   Fixed according to Manivannan Sadhasivam's comments, except endian
> problem. Endian problem is out of this patch series scope.
>   kernel test robot report sparse build warning problem already fixed
> at patch 6 and 7.
> 
> Change from v13-v14
>   split spare warning fix to two patch
>   remove local variable reorder
> 
> Frank Li (7):
>   PCI: endpoint: pci-epf-vntb: Clean up kernel_doc warning
>   PCI: endpoint: pci-epf-vntb: Fix indentation of the struct
>     epf_ntb_ctrl
>   PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr at err
>     path
>   PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy
>   PCI: endpoint: pci-epf-vntb: replace hardcode 4 with sizeof(u32)
>   PCI: endpoint: pci-epf-vntb: fix sparse build warning at epf_db
>   PCI: endpoint: pci-epf-vntb: fix sparse build warning at ntb->reg

Please capitalize your subject lines consistently.  You have two
capitalized:

> PCI: endpoint: pci-epf-vntb: Clean up ...
> PCI: endpoint: pci-epf-vntb: Fix indentation ...

and a bunch that aren't:

> PCI: endpoint: pci-epf-vntb: fix call ...
> PCI: endpoint: pci-epf-vntb: remove unused ...
> ...

Also add "()" after function names:

  PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr() ...