mbox series

[0/2] Revert ASPM L1 Substates updates

Message ID 20230203224820.2056582-1-helgaas@kernel.org (mailing list archive)
Headers show
Series Revert ASPM L1 Substates updates | expand

Message

Bjorn Helgaas Feb. 3, 2023, 10:48 p.m. UTC 
From: Bjorn Helgaas <bhelgaas@google.com>

Thomas Witt reported that 5e85eba6f50d ("PCI/ASPM: Refactor L1 PM
Substates Control Register programming") broke suspend/resume on a
Tuxedo Infinitybook S 14 v5, which seems to use a Clevo L140CU Mainboard.
See https://bugzilla.kernel.org/show_bug.cgi?id=216877

Since we haven't figured out a root cause, revert the relevant patches for
now.

Note that reverting "Save L1 PM Substates Capability for suspend/resume"
means machines will use more power after suspend/resume because the L1
Substates configuration is lost, but they should still work correctly.

Bjorn Helgaas (2):
  Revert "PCI/ASPM: Save L1 PM Substates Capability for suspend/resume"
  Revert "PCI/ASPM: Refactor L1 PM Substates Control Register
    programming"

 drivers/pci/pci.c       |   7 ---
 drivers/pci/pci.h       |   4 --
 drivers/pci/pcie/aspm.c | 109 ++++++++++++----------------------------
 3 files changed, 33 insertions(+), 87 deletions(-)