mbox series

[v5,0/7] PCI: dwc: rcar-gen4: Add R-Car V4H support

Message ID 20240408012458.3717977-1-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
Headers show
Series PCI: dwc: rcar-gen4: Add R-Car V4H support | expand

Message

Yoshihiro Shimoda April 8, 2024, 1:24 a.m. UTC
The pcie-rcar-gen4 driver can reuse other R-Car Gen4 support like
r8a779g0 (R-Car V4H) and r8a779h0 (R-Car V4M). However, some
initializing settings differ between R-Car S4-8 (r8a779f0) and
others. The R-Car S4-8 will be minority about the setting way. So,
R-Car V4H will be majority and this is generic initialization way
as "renesas,rcar-gen4-pcie{-ep}" compatible. For now, I tested
both R-Car S4-8 and R-Car V4H on this driver. I'll support one more
other SoC (R-Car V4M) in the future.

Changes from v4:
https://lore.kernel.org/linux-pci/20240403053304.3695096-1-yoshihiro.shimoda.uh@renesas.com/
- Fix compatible string for renesas,r8a779f0-pcie-ep which was described
  accidentally from v3...

Changes from v3:
https://lore.kernel.org/linux-pci/20240401023942.134704-1-yoshihiro.shimoda.uh@renesas.com/
- Modify the code to use "do .. while" instead of goto in patch 6/7.

Changes from v2:
https://lore.kernel.org/linux-pci/20240326024540.2336155-1-yoshihiro.shimoda.uh@renesas.com/
- Add a new patch which just add a platdata in patch 4/7.
- Modify the subjects in patch [56]/7.
- Modify the description and code about Bjorn's comment in patch [56]/7.
- Add missing MODULE_FIRMWARE(9 in patch 6/7.
- Document a policy aboud adding pci_device_id instead of adding r8a779g0's id
  in patch 7/7.

Changes from v1:
https://lore.kernel.org/linux-pci/20240229120719.2553638-1-yoshihiro.shimoda.uh@renesas.com/
- Based on v6.9-rc1.
- Add Acked-by and/or Reviewed-by in patch [126/6].

Yoshihiro Shimoda (7):
  dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car V4H compatible
  dt-bindings: PCI: rcar-gen4-pci-ep: Add R-Car V4H compatible
  PCI: dwc: Add PCIE_PORT_{FORCE,LANE_SKEW} macros
  PCI: dwc: rcar-gen4: Add rcar_gen4_pcie_platdata
  PCI: dwc: rcar-gen4: Add .ltssm_enable() for other SoC support
  PCI: dwc: rcar-gen4: Add support for r8a779g0
  misc: pci_endpoint_test: Document a policy about adding pci_device_id

 .../bindings/pci/rcar-gen4-pci-ep.yaml        |   4 +-
 .../bindings/pci/rcar-gen4-pci-host.yaml      |   4 +-
 drivers/misc/pci_endpoint_test.c              |   1 +
 drivers/pci/controller/dwc/pcie-designware.h  |   6 +
 drivers/pci/controller/dwc/pcie-rcar-gen4.c   | 272 +++++++++++++++++-
 5 files changed, 270 insertions(+), 17 deletions(-)

Comments

Bjorn Helgaas April 9, 2024, 1:28 p.m. UTC | #1
On Mon, Apr 08, 2024 at 10:24:51AM +0900, Yoshihiro Shimoda wrote:

> Yoshihiro Shimoda (7):
>   dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car V4H compatible
>   dt-bindings: PCI: rcar-gen4-pci-ep: Add R-Car V4H compatible
>   PCI: dwc: Add PCIE_PORT_{FORCE,LANE_SKEW} macros
>   PCI: dwc: rcar-gen4: Add rcar_gen4_pcie_platdata
>   PCI: dwc: rcar-gen4: Add .ltssm_enable() for other SoC support
>   PCI: dwc: rcar-gen4: Add support for r8a779g0

Previous history for this file uses a "PCI: rcar-gen4: " prefix
(without "dwc:").  I don't think we need to replicate the whole file
path here in the precious subject line space, so "PCI: rcar-gen4: "
should be enough.

>   misc: pci_endpoint_test: Document a policy about adding pci_device_id
> 
>  .../bindings/pci/rcar-gen4-pci-ep.yaml        |   4 +-
>  .../bindings/pci/rcar-gen4-pci-host.yaml      |   4 +-
>  drivers/misc/pci_endpoint_test.c              |   1 +
>  drivers/pci/controller/dwc/pcie-designware.h  |   6 +
>  drivers/pci/controller/dwc/pcie-rcar-gen4.c   | 272 +++++++++++++++++-
>  5 files changed, 270 insertions(+), 17 deletions(-)
> 
> -- 
> 2.25.1
>
Yoshihiro Shimoda April 10, 2024, 12:32 a.m. UTC | #2
Hi Bjorn,

> From: Bjorn Helgaas, Sent: Tuesday, April 9, 2024 10:28 PM
> 
> On Mon, Apr 08, 2024 at 10:24:51AM +0900, Yoshihiro Shimoda wrote:
> 
> > Yoshihiro Shimoda (7):
> >   dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car V4H compatible
> >   dt-bindings: PCI: rcar-gen4-pci-ep: Add R-Car V4H compatible
> >   PCI: dwc: Add PCIE_PORT_{FORCE,LANE_SKEW} macros
> >   PCI: dwc: rcar-gen4: Add rcar_gen4_pcie_platdata
> >   PCI: dwc: rcar-gen4: Add .ltssm_enable() for other SoC support
> >   PCI: dwc: rcar-gen4: Add support for r8a779g0
> 
> Previous history for this file uses a "PCI: rcar-gen4: " prefix
> (without "dwc:").  I don't think we need to replicate the whole file
> path here in the precious subject line space, so "PCI: rcar-gen4: "
> should be enough.

Oops. I'll fix the subjects.

Best regards,
Yoshihiro Shimoda

> >   misc: pci_endpoint_test: Document a policy about adding pci_device_id
> >
> >  .../bindings/pci/rcar-gen4-pci-ep.yaml        |   4 +-
> >  .../bindings/pci/rcar-gen4-pci-host.yaml      |   4 +-
> >  drivers/misc/pci_endpoint_test.c              |   1 +
> >  drivers/pci/controller/dwc/pcie-designware.h  |   6 +
> >  drivers/pci/controller/dwc/pcie-rcar-gen4.c   | 272 +++++++++++++++++-
> >  5 files changed, 270 insertions(+), 17 deletions(-)
> >
> > --
> > 2.25.1
> >