mbox series

[v2,0/2] PCI: kirin: cleanup (dev_err_probe() and scoped loop)

Message ID 20240707-pcie-kirin-dev_err_probe-v2-0-2fa94951d84d@gmail.com (mailing list archive)
Headers show
Series PCI: kirin: cleanup (dev_err_probe() and scoped loop) | expand

Message

Javier Carrasco July 7, 2024, 1:54 p.m. UTC 
This series removes some patterns that require multiple steps to achieve
what single calls can achieve.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Changes in v2:
- Remove error value from the message "failed to parse devfn: %d\n", as
  it is already handled by dev_err_probe().
- Fix capitalization in error messages.
- Return -ENODEV and provide more appropriate error message if no
  dev->of_node is available.
- Link to v1: https://lore.kernel.org/r/20240706-pcie-kirin-dev_err_probe-v1-0-56df797fb8ee@gmail.com

---
Javier Carrasco (2):
      PCI: kirin: use dev_err_probe() in probe error paths
      PCI: kirin: use for_each_available_child_of_node_scoped()

 drivers/pci/controller/dwc/pcie-kirin.c | 54 ++++++++++++---------------------
 1 file changed, 20 insertions(+), 34 deletions(-)
---
base-commit: 412d6f897b7a494b373986e63a14a94d0fbd0fdb
change-id: 20240705-pcie-kirin-dev_err_probe-0c9035188ff9

Best regards,

Comments

Krzysztof Wilczyński July 8, 2024, 12:42 a.m. UTC | #1 
Hello,

> This series removes some patterns that require multiple steps to achieve
> what single calls can achieve.

Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

... for botch patches.

	Krzysztof