diff mbox

PCI: dra7xx: Add dra7xx prefix before add_pcie_port

Message ID 001301cff95e$a124f6b0$e36ee410$%han@samsung.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Jingoo Han Nov. 6, 2014, 1:11 a.m. UTC
The add_pcie_port function is dra7xx-specific. Add exynos prefix
to avoid collision in global name space.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pci/host/pci-dra7xx.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Kishon Vijay Abraham I Nov. 6, 2014, 5:06 a.m. UTC | #1
On Thursday 06 November 2014 06:41 AM, Jingoo Han wrote:
> The add_pcie_port function is dra7xx-specific. Add exynos prefix
> to avoid collision in global name space.

%s/exynos/dra7xx

After fixing this you can add
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/pci/host/pci-dra7xx.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index 52b34fe..5b4a644 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -270,8 +270,8 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
>  	return IRQ_HANDLED;
>  }
>  
> -static int add_pcie_port(struct dra7xx_pcie *dra7xx,
> -			  struct platform_device *pdev)
> +static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> +				struct platform_device *pdev)
>  {
>  	int ret;
>  	struct pcie_port *pp;
> @@ -398,7 +398,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, dra7xx);
>  
> -	ret = add_pcie_port(dra7xx, pdev);
> +	ret = dra7xx_add_pcie_port(dra7xx, pdev);
>  	if (ret < 0)
>  		goto err_add_port;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jingoo Han Nov. 6, 2014, 5:27 a.m. UTC | #2
On Thursday, November 06, 2014 2:07 PM, Kishon Vijay Abraham I wrote:
> 
> On Thursday 06 November 2014 06:41 AM, Jingoo Han wrote:
> > The add_pcie_port function is dra7xx-specific. Add exynos prefix
> > to avoid collision in global name space.
> 
> %s/exynos/dra7xx

Sorry, it is my bad. I will send patch v2 soon.

> 
> After fixing this you can add
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

I appreciated you Acked-by.

Best regards,
Jingoo Han

> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> >  drivers/pci/host/pci-dra7xx.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index 52b34fe..5b4a644 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -270,8 +270,8 @@  static irqreturn_t dra7xx_pcie_irq_handler(int irq, void *arg)
 	return IRQ_HANDLED;
 }
 
-static int add_pcie_port(struct dra7xx_pcie *dra7xx,
-			  struct platform_device *pdev)
+static int dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
+				struct platform_device *pdev)
 {
 	int ret;
 	struct pcie_port *pp;
@@ -398,7 +398,7 @@  static int __init dra7xx_pcie_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, dra7xx);
 
-	ret = add_pcie_port(dra7xx, pdev);
+	ret = dra7xx_add_pcie_port(dra7xx, pdev);
 	if (ret < 0)
 		goto err_add_port;