diff mbox

PCI: spear: Add exynos spear13xx before add_pcie_port/pcie_init

Message ID 001401cff95e$ec061f60$c4125e20$%han@samsung.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Jingoo Han Nov. 6, 2014, 1:13 a.m. UTC 
The add_pcie_port/pcie_init functions are SPEAr13xx-specific.
Add exynos prefix to avoid collision in global name space.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pci/host/pcie-spear13xx.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Viresh Kumar Nov. 10, 2014, 6:36 a.m. UTC | #1 
On 6 November 2014 06:43, Jingoo Han <jg1.han@samsung.com> wrote:
> The add_pcie_port/pcie_init functions are SPEAr13xx-specific.
> Add exynos prefix to avoid collision in global name space.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/pci/host/pcie-spear13xx.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

The diff looks fine but log and subject aren't correct.. SPEAr13xx is
not an Exynos SoC, but is from ST Microelectronics.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
index 85f594e..63f869f 100644
--- a/drivers/pci/host/pcie-spear13xx.c
+++ b/drivers/pci/host/pcie-spear13xx.c
@@ -269,7 +269,8 @@  static struct pcie_host_ops spear13xx_pcie_host_ops = {
 	.host_init = spear13xx_pcie_host_init,
 };
 
-static int add_pcie_port(struct pcie_port *pp, struct platform_device *pdev)
+static int spear13xx_add_pcie_port(struct pcie_port *pp,
+				   struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	int ret;
@@ -352,7 +353,7 @@  static int __init spear13xx_pcie_probe(struct platform_device *pdev)
 	if (of_property_read_bool(np, "st,pcie-is-gen1"))
 		spear13xx_pcie->is_gen1 = true;
 
-	ret = add_pcie_port(pp, pdev);
+	ret = spear13xx_add_pcie_port(pp, pdev);
 	if (ret < 0)
 		goto fail_clk;
 
@@ -382,11 +383,11 @@  static struct platform_driver spear13xx_pcie_driver __initdata = {
 
 /* SPEAr13xx PCIe driver does not allow module unload */
 
-static int __init pcie_init(void)
+static int __init spear13xx_pcie_init(void)
 {
 	return platform_driver_register(&spear13xx_pcie_driver);
 }
-module_init(pcie_init);
+module_init(spear13xx_pcie_init);
 
 MODULE_DESCRIPTION("ST Microelectronics SPEAr13xx PCIe host controller driver");
 MODULE_AUTHOR("Pratyush Anand <pratyush.anand@st.com>");