Message ID | 12243017.yA3ijCk2M3@storm (mailing list archive) |
---|---|
State | New, archived |
Delegated to: | Bjorn Helgaas |
Headers | show |
On Fri, Aug 08, 2014 at 03:54:04PM +0200, Thomas Jarosch wrote: > New Intel G3258 CPU, new MSI board, same problem: > The GPU interrupt fired like crazy on monitor unplug. > > lspci output: > 00:02.0 VGA compatible controller: Intel Corporation Device 0402 (rev 06) > Subsystem: Micro-Star International Co., Ltd. Device 7817 > Flags: bus master, fast devsel, latency 0, IRQ 11 > > Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com> > Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com> > CC: stable@vger.kernel.org # v3.4+ > --- > drivers/pci/quirks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 80c2d01..d2ff39d 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -2940,6 +2940,7 @@ static void disable_igfx_irq(struct pci_dev *dev) > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq); > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq); > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0152, disable_igfx_irq); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0402, disable_igfx_irq); Shouldn't we just add entries for them all? See include/drm/i915_pciids.h We might need to abstract the macro magic a bit though to reuse that list. Also note that not all have the DEIER register. In any case I don't think this game of whack-a-mole here is, we should plug this all for real. -Daniel > > /* > * PCI devices which are on Intel chips can skip the 10ms delay > -- > 1.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Aug 08, 2014 at 03:54:04PM +0200, Thomas Jarosch wrote: > New Intel G3258 CPU, new MSI board, same problem: > The GPU interrupt fired like crazy on monitor unplug. > > lspci output: > 00:02.0 VGA compatible controller: Intel Corporation Device 0402 (rev 06) > Subsystem: Micro-Star International Co., Ltd. Device 7817 > Flags: bus master, fast devsel, latency 0, IRQ 11 > > Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com> > Tested-by: Thomas Jarosch <thomas.jarosch@intra2net.com> > CC: stable@vger.kernel.org # v3.4+ Dropping for now, please resend if necessary after resolving Daniel's question. > --- > drivers/pci/quirks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 80c2d01..d2ff39d 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -2940,6 +2940,7 @@ static void disable_igfx_irq(struct pci_dev *dev) > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq); > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq); > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0152, disable_igfx_irq); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0402, disable_igfx_irq); > > /* > * PCI devices which are on Intel chips can skip the 10ms delay > -- > 1.9.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 80c2d01..d2ff39d 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -2940,6 +2940,7 @@ static void disable_igfx_irq(struct pci_dev *dev) DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0102, disable_igfx_irq); DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x010a, disable_igfx_irq); DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0152, disable_igfx_irq); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0402, disable_igfx_irq); /* * PCI devices which are on Intel chips can skip the 10ms delay