diff mbox

PCI: fix htmldocs pci.c

Message ID 1253798147.10654.3.camel@ht.satnam
State Superseded, archived
Headers show

Commit Message

Jaswinder Singh Rajput Sept. 24, 2009, 1:15 p.m. UTC
Fix the following htmldocs warnings:

  Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
  Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
  Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
  Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Tiago Vignatti <tiago.vignatti@nokia.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/pci/pci.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Comments

Randy Dunlap Sept. 24, 2009, 3:54 p.m. UTC | #1
Jaswinder Singh Rajput wrote:
> Fix the following htmldocs warnings:
> 
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
>   Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>

Ack, but already sent to Jesse & linux-pci mailing list.

> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Tiago Vignatti <tiago.vignatti@nokia.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/pci/pci.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 6edecff..67288ec 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
>  
>  /**
>   * pci_set_vga_state - set VGA decode state on device and parents if requested
> - * @dev the PCI device
> - * @decode - true = enable decoding, false = disable decoding
> - * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> - * @change_bridge - traverse ancestors and change bridges
> + * @dev: the PCI device
> + * @decode: true = enable decoding, false = disable decoding
> + * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> + * @change_bridge: traverse ancestors and change bridges
>   */
>  int pci_set_vga_state(struct pci_dev *dev, bool decode,
>  		      unsigned int command_bits, bool change_bridge)

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tiago Vignatti Sept. 25, 2009, 9:48 a.m. UTC | #2
On Thu, Sep 24, 2009 at 05:54:15PM +0200, ext Randy Dunlap wrote:
> Jaswinder Singh Rajput wrote:
> > Fix the following htmldocs warnings:
> > 
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
> >   Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'
> > 
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> 
> Ack, but already sent to Jesse & linux-pci mailing list.

got my Ack also.
 
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Tiago Vignatti <tiago.vignatti@nokia.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Cc: Randy Dunlap <randy.dunlap@oracle.com>
> > ---
> >  drivers/pci/pci.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 6edecff..67288ec 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
> >  
> >  /**
> >   * pci_set_vga_state - set VGA decode state on device and parents if requested
> > - * @dev the PCI device
> > - * @decode - true = enable decoding, false = disable decoding
> > - * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> > - * @change_bridge - traverse ancestors and change bridges
> > + * @dev: the PCI device
> > + * @decode: true = enable decoding, false = disable decoding
> > + * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> > + * @change_bridge: traverse ancestors and change bridges
> >   */
> >  int pci_set_vga_state(struct pci_dev *dev, bool decode,
> >  		      unsigned int command_bits, bool change_bridge)
            Tiago
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 6edecff..67288ec 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2542,10 +2542,10 @@  int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
 
 /**
  * pci_set_vga_state - set VGA decode state on device and parents if requested
- * @dev the PCI device
- * @decode - true = enable decoding, false = disable decoding
- * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
- * @change_bridge - traverse ancestors and change bridges
+ * @dev: the PCI device
+ * @decode: true = enable decoding, false = disable decoding
+ * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
+ * @change_bridge: traverse ancestors and change bridges
  */
 int pci_set_vga_state(struct pci_dev *dev, bool decode,
 		      unsigned int command_bits, bool change_bridge)