| Message ID | 1370644273-10495-9-git-send-email-yinghai@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Fri, Jun 07, 2013 at 03:30:54PM -0700, Yinghai Lu wrote: > create_irq() will return -1 when failing to allocate. > create_irq_nr() will return 0 when failing to allocate. > > It only causes confusion. > > Now we have no user for create_irq(), so remove create_irq() for x86. Oh thank you so much. That is what I just asked for :) Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 436fb38..70b6617 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -2968,21 +2968,6 @@ unsigned int create_irq_nr(unsigned int from, int node) return __create_irqs(from, 1, node); } -int create_irq(void) -{ - int node = cpu_to_node(0); - unsigned int irq_want; - int irq; - - irq_want = nr_irqs_gsi; - irq = create_irq_nr(irq_want, node); - - if (irq == 0) - irq = -1; - - return irq; -} - void destroy_irq(unsigned int irq) { struct irq_cfg *cfg = irq_get_chip_data(irq);
create_irq() will return -1 when failing to allocate. create_irq_nr() will return 0 when failing to allocate. It only causes confusion. Now we have no user for create_irq(), so remove create_irq() for x86. Signed-off-by: Yinghai Lu <yinghai@kernel.org> Cc: Joerg Roedel <joro@8bytes.org> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> --- arch/x86/kernel/apic/io_apic.c | 15 --------------- 1 file changed, 15 deletions(-)