diff mbox

[07/13] PCI: Use list_add_(before|after) macros

Message ID 1402076072-4044-7-git-send-email-kenhelias@web.de (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Ken Helias June 6, 2014, 5:34 p.m. UTC 
From: Ken Helias <kenhelias@firemail.de>

Many places in the code uses list_add_tail/list_add to insert an entry
before/after another entry. This confuses the reader because these are usually
used to add an item to a list_head and not an entry. Better use the self
explaining function name.

Signed-off-by: Ken Helias <kenhelias@firemail.de>
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/setup-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index fd9b545..77ceaab 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -167,7 +167,7 @@  static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head)
 			}
 		}
 		/* Insert it just before n*/
-		list_add_tail(&tmp->list, n);
+		list_add_before(&tmp->list, n);
 	}
 }