| Message ID | 1403948683-10410-1-git-send-email-fabf@skynet.be (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Sat, Jun 28, 2014 at 11:44:43AM +0200, Fabian Frederick wrote: > Fix checkpatch warning: > "WARNING: debugfs_remove(NULL) is safe this check is probably not required" > > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Ryan Desfosses <ryan@desfo.org> > Cc: linux-pci@vger.kernel.org > Signed-off-by: Fabian Frederick <fabf@skynet.be> Applied to pci/hotplug for v3.17, thanks! > --- > drivers/pci/hotplug/cpqphp_sysfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c > index 4a392c4..d81648f 100644 > --- a/drivers/pci/hotplug/cpqphp_sysfs.c > +++ b/drivers/pci/hotplug/cpqphp_sysfs.c > @@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl) > > void cpqhp_remove_debugfs_files(struct controller *ctrl) > { > - if (ctrl->dentry) > - debugfs_remove(ctrl->dentry); > + debugfs_remove(ctrl->dentry); > ctrl->dentry = NULL; > } > > -- > 1.8.4.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c index 4a392c4..d81648f 100644 --- a/drivers/pci/hotplug/cpqphp_sysfs.c +++ b/drivers/pci/hotplug/cpqphp_sysfs.c @@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl) void cpqhp_remove_debugfs_files(struct controller *ctrl) { - if (ctrl->dentry) - debugfs_remove(ctrl->dentry); + debugfs_remove(ctrl->dentry); ctrl->dentry = NULL; }
Fix checkpatch warning: "WARNING: debugfs_remove(NULL) is safe this check is probably not required" Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Ryan Desfosses <ryan@desfo.org> Cc: linux-pci@vger.kernel.org Signed-off-by: Fabian Frederick <fabf@skynet.be> --- drivers/pci/hotplug/cpqphp_sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)