| Message ID | 1411134450-806-1-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Am Freitag, den 19.09.2014, 10:47 -0300 schrieb Fabio Estevam: > of_get_address() expects pointers in the third and fourth parameters. > > Pass NULL in order to fix the following sparse warnings: > > drivers/pci/host/pcie-designware.c:433:51: warning: Using plain integer as NULL pointer > drivers/pci/host/pcie-designware.c:433:58: warning: Using plain integer as NULL pointer > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/pci/host/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 12c42fc..f1f0b7a 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -430,7 +430,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp) > > /* Find the untranslated configuration space address */ > index = of_property_match_string(np, "reg-names", "config"); > - addrp = of_get_address(np, index, false, false); > + addrp = of_get_address(np, index, NULL, NULL); > pp->cfg0_mod_base = of_read_number(addrp, ns); > pp->cfg1_mod_base = pp->cfg0_mod_base + pp->config.cfg0_size; > } else {
On Friday, September 19, 2014 10:48 PM, Fabio Estevam wrote: > > of_get_address() expects pointers in the third and fourth parameters. > > Pass NULL in order to fix the following sparse warnings: > > drivers/pci/host/pcie-designware.c:433:51: warning: Using plain integer as NULL pointer > drivers/pci/host/pcie-designware.c:433:58: warning: Using plain integer as NULL pointer > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > --- > drivers/pci/host/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 12c42fc..f1f0b7a 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -430,7 +430,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp) > > /* Find the untranslated configuration space address */ > index = of_property_match_string(np, "reg-names", "config"); > - addrp = of_get_address(np, index, false, false); > + addrp = of_get_address(np, index, NULL, NULL); > pp->cfg0_mod_base = of_read_number(addrp, ns); > pp->cfg1_mod_base = pp->cfg0_mod_base + pp->config.cfg0_size; > } else { > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Sep 19, 2014 at 10:47:30AM -0300, Fabio Estevam wrote: > of_get_address() expects pointers in the third and fourth parameters. > > Pass NULL in order to fix the following sparse warnings: > > drivers/pci/host/pcie-designware.c:433:51: warning: Using plain integer as NULL pointer > drivers/pci/host/pcie-designware.c:433:58: warning: Using plain integer as NULL pointer > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Applied with acks from Lucas and Jingoo to pci/host-designware for v3.18, thanks! > --- > drivers/pci/host/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 12c42fc..f1f0b7a 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -430,7 +430,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp) > > /* Find the untranslated configuration space address */ > index = of_property_match_string(np, "reg-names", "config"); > - addrp = of_get_address(np, index, false, false); > + addrp = of_get_address(np, index, NULL, NULL); > pp->cfg0_mod_base = of_read_number(addrp, ns); > pp->cfg1_mod_base = pp->cfg0_mod_base + pp->config.cfg0_size; > } else { > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 12c42fc..f1f0b7a 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -430,7 +430,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp) /* Find the untranslated configuration space address */ index = of_property_match_string(np, "reg-names", "config"); - addrp = of_get_address(np, index, false, false); + addrp = of_get_address(np, index, NULL, NULL); pp->cfg0_mod_base = of_read_number(addrp, ns); pp->cfg1_mod_base = pp->cfg0_mod_base + pp->config.cfg0_size; } else {
of_get_address() expects pointers in the third and fourth parameters. Pass NULL in order to fix the following sparse warnings: drivers/pci/host/pcie-designware.c:433:51: warning: Using plain integer as NULL pointer drivers/pci/host/pcie-designware.c:433:58: warning: Using plain integer as NULL pointer Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- drivers/pci/host/pcie-designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)