| Message ID | 1438371404-3219-5-git-send-email-sean.stalley@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Acked-by: Julia Lawall <julia.lawall@lip6.fr> On Fri, 31 Jul 2015, Sean O. Stalley wrote: > add [pci|dma]_pool_zalloc coccinelle check. > replaces instances of [pci|dma]_pool_alloc() followed by memset(0) > with [pci|dma]_pool_zalloc(). > > Signed-off-by: Sean O. Stalley <sean.stalley@intel.com> > --- > .../coccinelle/api/alloc/pool_zalloc-simple.cocci | 84 ++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci > > diff --git a/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci b/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci > new file mode 100644 > index 0000000..9b7eb32 > --- /dev/null > +++ b/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci > @@ -0,0 +1,84 @@ > +/// > +/// Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0 > +/// > +// Copyright: (C) 2015 Intel Corp. GPLv2. > +// Options: --no-includes --include-headers > +// > +// Keywords: dma_pool_zalloc, pci_pool_zalloc > +// > + > +virtual context > +virtual patch > +virtual org > +virtual report > + > +//---------------------------------------------------------- > +// For context mode > +//---------------------------------------------------------- > + > +@depends on context@ > +expression x; > +statement S; > +@@ > + > +* x = \(dma_pool_alloc\|pci_pool_alloc\)(...); > + if ((x==NULL) || ...) S > +* memset(x,0, ...); > + > +//---------------------------------------------------------- > +// For patch mode > +//---------------------------------------------------------- > + > +@depends on patch@ > +expression x; > +expression a,b,c; > +statement S; > +@@ > + > +- x = dma_pool_alloc(a,b,c); > ++ x = dma_pool_zalloc(a,b,c); > + if ((x==NULL) || ...) S > +- memset(x,0,...); > + > +@depends on patch@ > +expression x; > +expression a,b,c; > +statement S; > +@@ > + > +- x = pci_pool_alloc(a,b,c); > ++ x = pci_pool_zalloc(a,b,c); > + if ((x==NULL) || ...) S > +- memset(x,0,...); > + > +//---------------------------------------------------------- > +// For org and report mode > +//---------------------------------------------------------- > + > +@r depends on org || report@ > +expression x; > +expression a,b,c; > +statement S; > +position p; > +@@ > + > + x = @p\(dma_pool_alloc\|pci_pool_alloc\)(a,b,c); > + if ((x==NULL) || ...) S > + memset(x,0, ...); > + > +@script:python depends on org@ > +p << r.p; > +x << r.x; > +@@ > + > +msg="%s" % (x) > +msg_safe=msg.replace("[","@(").replace("]",")") > +coccilib.org.print_todo(p[0], msg_safe) > + > +@script:python depends on report@ > +p << r.p; > +x << r.x; > +@@ > + > +msg="WARNING: *_pool_zalloc should be used for %s, instead of *_pool_alloc/memset" % (x) > +coccilib.report.print_report(p[0], msg) > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci b/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci new file mode 100644 index 0000000..9b7eb32 --- /dev/null +++ b/scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci @@ -0,0 +1,84 @@ +/// +/// Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0 +/// +// Copyright: (C) 2015 Intel Corp. GPLv2. +// Options: --no-includes --include-headers +// +// Keywords: dma_pool_zalloc, pci_pool_zalloc +// + +virtual context +virtual patch +virtual org +virtual report + +//---------------------------------------------------------- +// For context mode +//---------------------------------------------------------- + +@depends on context@ +expression x; +statement S; +@@ + +* x = \(dma_pool_alloc\|pci_pool_alloc\)(...); + if ((x==NULL) || ...) S +* memset(x,0, ...); + +//---------------------------------------------------------- +// For patch mode +//---------------------------------------------------------- + +@depends on patch@ +expression x; +expression a,b,c; +statement S; +@@ + +- x = dma_pool_alloc(a,b,c); ++ x = dma_pool_zalloc(a,b,c); + if ((x==NULL) || ...) S +- memset(x,0,...); + +@depends on patch@ +expression x; +expression a,b,c; +statement S; +@@ + +- x = pci_pool_alloc(a,b,c); ++ x = pci_pool_zalloc(a,b,c); + if ((x==NULL) || ...) S +- memset(x,0,...); + +//---------------------------------------------------------- +// For org and report mode +//---------------------------------------------------------- + +@r depends on org || report@ +expression x; +expression a,b,c; +statement S; +position p; +@@ + + x = @p\(dma_pool_alloc\|pci_pool_alloc\)(a,b,c); + if ((x==NULL) || ...) S + memset(x,0, ...); + +@script:python depends on org@ +p << r.p; +x << r.x; +@@ + +msg="%s" % (x) +msg_safe=msg.replace("[","@(").replace("]",")") +coccilib.org.print_todo(p[0], msg_safe) + +@script:python depends on report@ +p << r.p; +x << r.x; +@@ + +msg="WARNING: *_pool_zalloc should be used for %s, instead of *_pool_alloc/memset" % (x) +coccilib.report.print_report(p[0], msg)
add [pci|dma]_pool_zalloc coccinelle check. replaces instances of [pci|dma]_pool_alloc() followed by memset(0) with [pci|dma]_pool_zalloc(). Signed-off-by: Sean O. Stalley <sean.stalley@intel.com> --- .../coccinelle/api/alloc/pool_zalloc-simple.cocci | 84 ++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci