Message ID | 1439487436-26989-2-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
---|---|
State | New, archived |
Delegated to: | Bjorn Helgaas |
Headers | show
Return-Path: <linux-pci-owner@kernel.org> X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 85522C05AC for <patchwork-linux-pci@patchwork.kernel.org>; Thu, 13 Aug 2015 17:53:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BA6E32039E for <patchwork-linux-pci@patchwork.kernel.org>; Thu, 13 Aug 2015 17:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07BCA20382 for <patchwork-linux-pci@patchwork.kernel.org>; Thu, 13 Aug 2015 17:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbbHMRxJ (ORCPT <rfc822;patchwork-linux-pci@patchwork.kernel.org>); Thu, 13 Aug 2015 13:53:09 -0400 Received: from mail-bn1bn0108.outbound.protection.outlook.com ([157.56.110.108]:52256 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753139AbbHMRxH (ORCPT <rfc822;linux-pci@vger.kernel.org>); Thu, 13 Aug 2015 13:53:07 -0400 Received: from BY2PR03CA055.namprd03.prod.outlook.com (10.141.249.28) by BY1PR0301MB1303.namprd03.prod.outlook.com (10.161.206.152) with Microsoft SMTP Server (TLS) id 15.1.225.19; Thu, 13 Aug 2015 17:37:47 +0000 Received: from BL2FFO11FD044.protection.gbl (2a01:111:f400:7c09::126) by BY2PR03CA055.outlook.office365.com (2a01:111:e400:2c5d::28) with Microsoft SMTP Server (TLS) id 15.1.231.21 via Frontend Transport; Thu, 13 Aug 2015 17:37:47 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; ti.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD044.mail.protection.outlook.com (10.173.161.140) with Microsoft SMTP Server (TLS) id 15.1.243.9 via Frontend Transport; Thu, 13 Aug 2015 17:37:46 +0000 Received: from fabio-Latitude-E6410.am.freescale.net ([10.29.244.122]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id t7DHbgct030697; Thu, 13 Aug 2015 10:37:44 -0700 From: Fabio Estevam <fabio.estevam@freescale.com> To: <bhelgaas@google.com> CC: <linux-pci@vger.kernel.org>, Fabio Estevam <fabio.estevam@freescale.com>, Kishon Vijay Abraham I <kishon@ti.com> Subject: [PATCH 2/4] PCI: dra7xx: Remove unneeded use of IS_ERR_VALUE() Date: Thu, 13 Aug 2015 14:37:14 -0300 Message-ID: <1439487436-26989-2-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1439487436-26989-1-git-send-email-fabio.estevam@freescale.com> References: <1439487436-26989-1-git-send-email-fabio.estevam@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD044; 1:JdloM8P1d083bAvq5yjTsQdpgdrQSP0RPkyHearqV+ZS7uTO8eQyDnlSAYeJIfCgsNL+4Gl2A2hR+MM6Iat0lnYB/hgZQ8bJjOT5G2BOt7Amgl7YLpb4mNE2gthHsA4lCSYfyC1qZqoe2aTzP+J2Fn/DhNdr1CuC0qPxCiRorBI7OasVschw+41LKcHvyzjW7DAOKyHW7mucYoWpl4q4/fF/s7UsMl2h2yKrmrbUiKYoZD1SlQ7jbnA2rgK5jEw2BzxOWtvBJvjOTDI20F5vUTTmUL2uounA3x8GYGcnTbse3hRzTl7KynB4z4tHxWiyh1l6My5AdZzJU6+ord8oAISZO6m8h+dcd4CNH8y2QeBppHXXDuNW8XAOHDEGwB6j4Tuk8icl54+flNh/WMVvGA== X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2970300002)(339900001)(3050300001)(199003)(189002)(92566002)(106466001)(87936001)(105606002)(2950100001)(68736005)(110136002)(5001960100002)(19580395003)(97736004)(4001540100001)(6806004)(19580405001)(5003940100001)(36756003)(64706001)(5001830100001)(5001860100001)(50466002)(47776003)(81156007)(48376002)(86362001)(69596002)(50226001)(2351001)(85426001)(33646002)(46102003)(189998001)(77096005)(5001920100001)(104016003)(77156002)(50986999)(229853001)(62966003)(76176999); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0301MB1303; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:3; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1303; 2:ksCjD8vby07duBG/3P+NgZG7oubLS6kNUJoPbG9aIqtGy+6BZB+BWqnFmxnchxYrRKQBS3uDBTHJAnjgprpq8vRhurfNeIGgfU5QW7alsz+0fgmsM5ts64hOfJv21snCGeS2ERCokHefzvMAZ/dDdKPOpqabdwDJySf49lDmw88=; 3:TGwBecmrbOkrZ8IgiU2F8RZzf3xyZUC9xOB4muvx3JogYc6J9pxaD79RaakWomU5P3InsXd1FTvtIdNt0qDV34Q/EmLkQ0D41/JZKV1Aeu0KprHmH+Bd0gKFxi8Tg9uJbFRM05RNwTz7McgXvHPO9XT0oWS6N/9MDwy5fZLYNhdsqBjhgbAKn+KevqXSsu7xLZiF4ELmLnY6CQ4oTmN5ErQSwQ/VnReFqGOwhCYwre4=; 25:FSehW4A22CJZDhk8utuq5dPeAeZGqBxFom7CxqpeSMhTYkTzG4uSoD7UW2ik4rmfoe3NODDHZvJ12RktQczDpYmV7d0R6/wPx2xBPV/oNZewlfybM1CUhr2I1HMbPi1GdofaJL0MchOKadREBamTraL0UYlMr1mPQT+thZqV0TlnYKazJ7UVgeTmf5EvisrgepzprA6oAN89eJV97FPYENoyabk7M+X6sKURiX5X3QGPC5pdL2W/hcn70bkioAFejHvtSrMzT3RrIHzSTU6JbQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1303; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1303; 20:NzAjRGNpUzsX916h1HrZcUioQm0tFJ6UNpJeB2H39xhMaIFzbkUXId3LXJJBIcIHZ/pc8LLP946PYPXK4ErIOckXS9vmuqmo5cb+hjvx0I2sk3YZ0TJxY0C+YaFK1nQEtqwdy0N4pWMA9uoiLaTBMZQt5X1Tnrlbay43vN4twcToF8T/HgqWwVFqu0aUzI4YEyyIh/yHMpc0MiH+ws6EdK9wqEwJJmovbEtJNucPcypqAjPF8J8kogaojLeD/PObXWF190icpDJiuKsP5B+WGXvo9RmHszN/aNom1cuZg7tGJ7flC/ZLPXp5KUIUv2xqUblpsimok4hqbCgUVlMxrMsCs9TRk1IRB/C1d/fXGPs=; 4:0UUKctug0dFJtW9GlQX5M5JZo7gxpGHGcd8jYlzuqSZnQLkN0gCKoSWkW0SzDKEDh9+pSaqCn/5R4xkOvycdEOR1gsv8ipj6GwvkXX1HTd8kN9BaO4d56EHonFjA6YwrsKxzchV3GeWCF4C/WJ8O+09hL/rlagvYTf+nBkasUo2O3vlQ1XimJaej4q30T644sKO66mpFkQHbZLSBZvY/LQwrRuxpNgDNxGe3p8Vqy2egyl1Zwvo8RK03KWcP24JbDEy6tutcNEuB4v9LbMCxcRyFxNee0w4QGWgoFsAMj/0= X-Microsoft-Antispam-PRVS: <BY1PR0301MB130382182990D904928B9A8FE97D0@BY1PR0301MB1303.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BY1PR0301MB1303; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0301MB1303; X-Forefront-PRVS: 0667289FF8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0301MB1303; 23:4Ifgt3gt7S3P/EpaUH9YvtlT9sd/t468c9rthbk?= =?us-ascii?Q?g8SZzaT8A2PrVXtaEYj3dw1cMXtIgSZkB+qM/ha7pCU4Cvl2JejsO26lYjIO?= =?us-ascii?Q?Aj8SFsEIHbVyW0lPqOk6jlth3S4pS+baUIEoprn63FJRLEUkNT633U4I46r9?= =?us-ascii?Q?Fn/aBJFPurZKAKn3zuWNQ2HemCxf65UL14hodlRF1Suwe9Nk+j9zQfwC9d2t?= =?us-ascii?Q?9+QkcNUMdiRZBneKemWWcBJ/3x21egm5+sZdJNtWEJ6IP1njrq4ea+lC9LB5?= =?us-ascii?Q?a8uVYylD6mN2LjsUh8dFyq/TZQ9biuLYG971jLJBFu7xgd/hLjcymn15k13f?= =?us-ascii?Q?hQM6pUJHEYRSu4+qfZqn0HaaSjE2aDek3eqTMVvE/8CsCy5NYtcu73iU4qC3?= =?us-ascii?Q?6yZvKotA4uBM9JnBrnlWL6iux9nOEMHFDO8gtksuR/7QzbXRTNaVkB67tErZ?= =?us-ascii?Q?DqGV7dbjeNcvcbU9j4xLbsAumHZsFRGRMTgDBkFDj2XYh2untn43r4czlETx?= =?us-ascii?Q?F8rHskSQpAa/L/9pLCRy8HyXT7yMhHkfwl3IZwaXKncNuhnf0kXWIGgRCIyP?= =?us-ascii?Q?hE9QNvbqC1JntecJYaTWjf7KRYu5A2r8dBDReayfO8KLqk599LNiKYlWdPhb?= =?us-ascii?Q?eC4jEVDeJ0HWmMhzaKa0OAzvSjJJMWo6xE4gFdOLT7sg5RNIJqtmHGIiXpI6?= =?us-ascii?Q?VNyt0UPEvWcLOZw9mgtiLXNGZ2aMLzts9TBauqPfdMDOMlB/f/HxSy//13Sb?= =?us-ascii?Q?YLOGVJsvTdwKMvednnDX6LSHjdhnpKEFac4UHgIa1he87AJSw8quLWL1ffSK?= =?us-ascii?Q?eT2M774NAg9bV1/uuwMqdHZYI0n6U2o6DBNOCgMNPb+nZeSHGo227N/hQDJ7?= =?us-ascii?Q?/+DNI95RVLZ9rl4U3pXOvkno00oaeXEjNVZ7FuFm538IVW51KdkogTc+dPTk?= =?us-ascii?Q?cv8OlC9RM/aU0+2WftbzgDKTkyeIgVewqRjNq2QN65ZeG6At3Hc28VzQcgfY?= =?us-ascii?Q?dFZgaBOryM/t0Ambt9y4SpM3y/lMSjeWr4Lr3CAsIzCTZ2f6pzKCYwe6R1BG?= =?us-ascii?Q?4roIZYSGQ4HRuFRseBMzPPAULyPSoEFj46mQcHSvlS1DveVPyWTjtPb07b1U?= =?us-ascii?Q?PUWGpt0NlFNljN7f+PZBR0xITxFz+Yw+7rrS5wKCCW8X22RX77FQOUQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1303; 5:08htEoR9kW2XT06ex38byu+l+C6FuAkZ9B1anXSzF+rz2AX3bMi9+5GLKAYb3BNS5LFwzDyDY0Vnc7zrfSPIP8knV3tbzgaiBlsAUuf52fAZH04BMyrr+hp7cesPFFbXB5hz7OJn2OeTBBht6kw13w==; 24:TNakRr4QLtbUKNpiqfd/vOoimBVaXvbpKJ14JYEiuKOUabWkcqSvZXV8DBjZhePi00bHmPbZLWIVbNwES38wbvxvHiz36yxRIJk7fYIxGOE=; 20:WjYXKjYcyD5uUrJZnUn0EdXQiT8RAS5Lky+iTSSqE6W/ak7S1ZT/Z26QAesPZ8kuySSF7Dg8xH+Wa206nehunw== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2015 17:37:46.1406 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1303 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: <linux-pci.vger.kernel.org> X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c index 80db09e..8d72bb9 100644 --- a/drivers/pci/host/pci-dra7xx.c +++ b/drivers/pci/host/pci-dra7xx.c @@ -382,7 +382,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) pm_runtime_enable(dev); ret = pm_runtime_get_sync(dev); - if (IS_ERR_VALUE(ret)) { + if (ret < 0) { dev_err(dev, "pm_runtime_get_sync failed\n"); goto err_phy; }
There is no need to use the IS_ERR_VALUE() macro for checking the return value from pm_runtime_* functions. Just do a simple negative test instead. The semantic patch that makes this change is available in scripts/coccinelle/api/pm_runtime.cocci. Cc: Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- drivers/pci/host/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)