diff mbox

[v2,06/12] drivers:hv: Export do_hypercall()

Message ID 1441929670-10058-7-git-send-email-jakeo@microsoft.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Jake Oshins Sept. 11, 2015, 12:01 a.m. UTC
From: Jake Oshins <jakeo@microsoft.com>

This patch exposes the function that hv_vmbus.ko uses to make hypercalls.  This
is necessary for retargeting an interrupt when it is given a new affinity.

Signed-off-by: Jake Oshins <jakeo@microsoft.com>
---
 drivers/hv/hv.c        | 3 ++-
 include/linux/hyperv.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

KY Srinivasan Sept. 15, 2015, 11:27 p.m. UTC | #1
> -----Original Message-----
> From: jakeo@microsoft.com [mailto:jakeo@microsoft.com]
> Sent: Thursday, September 10, 2015 5:01 PM
> To: gregkh@linuxfoundation.org; KY Srinivasan <kys@microsoft.com>; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; vkuznets@redhat.com; linux-pci@vger.kernel.org;
> bhelgaas@google.com; tglx@linutronix.de
> Cc: Jake Oshins <jakeo@microsoft.com>
> Subject: [PATCH v2 06/12] drivers:hv: Export do_hypercall()
> 
> From: Jake Oshins <jakeo@microsoft.com>
> 
> This patch exposes the function that hv_vmbus.ko uses to make hypercalls.
> This
> is necessary for retargeting an interrupt when it is given a new affinity.
> 
> Signed-off-by: Jake Oshins <jakeo@microsoft.com>
> ---
>  drivers/hv/hv.c        | 3 ++-
>  include/linux/hyperv.h | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index 6341be8..6d01649 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -91,7 +91,7 @@ static int query_hypervisor_info(void)
>  /*
>   * do_hypercall- Invoke the specified hypercall
>   */
> -static u64 do_hypercall(u64 control, void *input, void *output)
> +u64 do_hypercall(u64 control, void *input, void *output)

do_hypercall() is not an appropriate name for a function to be exported. I plan to take the base
vmbus patches through Greg's tree and if it is ok with you, I will change the name of this function.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jake Oshins Sept. 15, 2015, 11:29 p.m. UTC | #2
> > ---
> > @@ -91,7 +91,7 @@ static int query_hypervisor_info(void)
> >  /*
> >   * do_hypercall- Invoke the specified hypercall
> >   */
> > -static u64 do_hypercall(u64 control, void *input, void *output)
> > +u64 do_hypercall(u64 control, void *input, void *output)
> 
> do_hypercall() is not an appropriate name for a function to be exported. I
> plan to take the base
> vmbus patches through Greg's tree and if it is ok with you, I will change the
> name of this function.
> 
> Regards,
> 
> K. Y

Of course.  Thanks.

-- Jake Oshins

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 6341be8..6d01649 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -91,7 +91,7 @@  static int query_hypervisor_info(void)
 /*
  * do_hypercall- Invoke the specified hypercall
  */
-static u64 do_hypercall(u64 control, void *input, void *output)
+u64 do_hypercall(u64 control, void *input, void *output)
 {
 	u64 input_address = (input) ? virt_to_phys(input) : 0;
 	u64 output_address = (output) ? virt_to_phys(output) : 0;
@@ -132,6 +132,7 @@  static u64 do_hypercall(u64 control, void *input, void *output)
 	return hv_status_lo | ((u64)hv_status_hi << 32);
 #endif /* !x86_64 */
 }
+EXPORT_SYMBOL_GPL(do_hypercall);
 
 #ifdef CONFIG_X86_64
 static cycle_t read_hv_clock_tsc(struct clocksource *arg)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 02393b6..033fe59 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -983,6 +983,7 @@  int vmbus_allocate_mmio(struct resource **new, struct hv_device *device_obj,
 			bool fb_overlap_ok);
 
 int vmbus_cpu_number_to_vp_number(int cpu_number);
+u64 do_hypercall(u64 control, void *input, void *output);
 
 /**
  * VMBUS_DEVICE - macro used to describe a specific hyperv vmbus device