diff mbox

PCI: designware: Remove unused variable

Message ID 1452512470-20890-1-git-send-email-fabio.estevam@nxp.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Fabio Estevam Jan. 11, 2016, 11:41 a.m. UTC
Commit 50a1a3b06dddaa5b ("PCI: designware: Simplify control flow")
causes the following build warning:

drivers/pci/host/pcie-designware.c:683:6: warning: unused variable 'ret' [-Wunused-variable]

Remove the unused 'ret' varaible.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/pci/host/pcie-designware.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bjorn Helgaas Jan. 11, 2016, 2:43 p.m. UTC | #1
On Mon, Jan 11, 2016 at 09:41:10AM -0200, Fabio Estevam wrote:
> Commit 50a1a3b06dddaa5b ("PCI: designware: Simplify control flow")
> causes the following build warning:
> 
> drivers/pci/host/pcie-designware.c:683:6: warning: unused variable 'ret' [-Wunused-variable]
> 
> Remove the unused 'ret' varaible.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Thanks guys, sorry about this oversight.  I folded this into the original
patch.

> ---
>  drivers/pci/host/pcie-designware.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 9a666db..2171682 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -680,7 +680,6 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,
>  			int where, int size, u32 val)
>  {
>  	struct pcie_port *pp = bus->sysdata;
> -	int ret;
>  
>  	if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)
>  		return PCIBIOS_DEVICE_NOT_FOUND;
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 9a666db..2171682 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -680,7 +680,6 @@  static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,
 			int where, int size, u32 val)
 {
 	struct pcie_port *pp = bus->sysdata;
-	int ret;
 
 	if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)
 		return PCIBIOS_DEVICE_NOT_FOUND;