| Message ID | 1453581859-19565-1-git-send-email-wuninsu@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Saturday, January 23, 2016 03:44:19 PM Insu Yun wrote: > In acpiphp_enable_slot, there is a missing unlock path > when error occurred. It needs to be unlocked before returning an error. > > Signed-off-by: Insu Yun <wuninsu@gmail.com> Applied, thanks! > --- > drivers/pci/hotplug/acpiphp_glue.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c > index ff53856..0b3e0bf 100644 > --- a/drivers/pci/hotplug/acpiphp_glue.c > +++ b/drivers/pci/hotplug/acpiphp_glue.c > @@ -953,8 +953,10 @@ int acpiphp_enable_slot(struct acpiphp_slot *slot) > { > pci_lock_rescan_remove(); > > - if (slot->flags & SLOT_IS_GOING_AWAY) > + if (slot->flags & SLOT_IS_GOING_AWAY) { > + pci_unlock_rescan_remove(); > return -ENODEV; > + } > > /* configure all functions */ > if (!(slot->flags & SLOT_ENABLED)) >
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index ff53856..0b3e0bf 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -953,8 +953,10 @@ int acpiphp_enable_slot(struct acpiphp_slot *slot) { pci_lock_rescan_remove(); - if (slot->flags & SLOT_IS_GOING_AWAY) + if (slot->flags & SLOT_IS_GOING_AWAY) { + pci_unlock_rescan_remove(); return -ENODEV; + } /* configure all functions */ if (!(slot->flags & SLOT_ENABLED))
In acpiphp_enable_slot, there is a missing unlock path when error occurred. It needs to be unlocked before returning an error. Signed-off-by: Insu Yun <wuninsu@gmail.com> --- drivers/pci/hotplug/acpiphp_glue.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)