diff mbox

PCI: iproc: remove unused struct iproc_pcie *pcie

Message ID 1499852825-64990-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Shawn Lin July 12, 2017, 9:47 a.m. UTC
It was never used and could be removed, otherwise
we could see a warning:

drivers/pci/host/pcie-iproc-msi.c: In function 'iproc_msi_handler':
drivers/pci/host/pcie-iproc-msi.c:320:21: warning: variable 'pcie' set
but not used [-Wunused-but-set-variable]

Cc: Ray Jui <rjui@broadcom.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/pci/host/pcie-iproc-msi.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Bjorn Helgaas July 13, 2017, 3:29 a.m. UTC | #1
On Wed, Jul 12, 2017 at 05:47:05PM +0800, Shawn Lin wrote:
> It was never used and could be removed, otherwise
> we could see a warning:
> 
> drivers/pci/host/pcie-iproc-msi.c: In function 'iproc_msi_handler':
> drivers/pci/host/pcie-iproc-msi.c:320:21: warning: variable 'pcie' set
> but not used [-Wunused-but-set-variable]
> 
> Cc: Ray Jui <rjui@broadcom.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Applied to pci/host-iproc for v4.14, thanks!

> ---
> 
>  drivers/pci/host/pcie-iproc-msi.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/host/pcie-iproc-msi.c b/drivers/pci/host/pcie-iproc-msi.c
> index 9fad791..2d0f535 100644
> --- a/drivers/pci/host/pcie-iproc-msi.c
> +++ b/drivers/pci/host/pcie-iproc-msi.c
> @@ -317,7 +317,6 @@ static void iproc_msi_handler(struct irq_desc *desc)
>  	struct irq_chip *chip = irq_desc_get_chip(desc);
>  	struct iproc_msi_grp *grp;
>  	struct iproc_msi *msi;
> -	struct iproc_pcie *pcie;
>  	u32 eq, head, tail, nr_events;
>  	unsigned long hwirq;
>  	int virq;
> @@ -326,7 +325,6 @@ static void iproc_msi_handler(struct irq_desc *desc)
>  
>  	grp = irq_desc_get_handler_data(desc);
>  	msi = grp->msi;
> -	pcie = msi->pcie;
>  	eq = grp->eq;
>  
>  	/*
> -- 
> 1.9.1
> 
>
diff mbox

Patch

diff --git a/drivers/pci/host/pcie-iproc-msi.c b/drivers/pci/host/pcie-iproc-msi.c
index 9fad791..2d0f535 100644
--- a/drivers/pci/host/pcie-iproc-msi.c
+++ b/drivers/pci/host/pcie-iproc-msi.c
@@ -317,7 +317,6 @@  static void iproc_msi_handler(struct irq_desc *desc)
 	struct irq_chip *chip = irq_desc_get_chip(desc);
 	struct iproc_msi_grp *grp;
 	struct iproc_msi *msi;
-	struct iproc_pcie *pcie;
 	u32 eq, head, tail, nr_events;
 	unsigned long hwirq;
 	int virq;
@@ -326,7 +325,6 @@  static void iproc_msi_handler(struct irq_desc *desc)
 
 	grp = irq_desc_get_handler_data(desc);
 	msi = grp->msi;
-	pcie = msi->pcie;
 	eq = grp->eq;
 
 	/*