| Message ID | 1500755119-19983-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Hello, On Sat, 22 Jul 2017 17:25:19 -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > clk_prepare_enable() may fail, so we should better check its return value > and propagate it in the case of error. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Thanks! Thomas
On Sat, Jul 22, 2017 at 05:25:19PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > clk_prepare_enable() may fail, so we should better check its return value > and propagate it in the case of error. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> Applied with Thomas' ack to pci/host-armada for v4.14, thanks! > --- > Changes since v1: > - Improve Subject style > > drivers/pci/dwc/pcie-armada8k.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/dwc/pcie-armada8k.c b/drivers/pci/dwc/pcie-armada8k.c > index ea8f34a..7297223 100644 > --- a/drivers/pci/dwc/pcie-armada8k.c > +++ b/drivers/pci/dwc/pcie-armada8k.c > @@ -226,7 +226,9 @@ static int armada8k_pcie_probe(struct platform_device *pdev) > if (IS_ERR(pcie->clk)) > return PTR_ERR(pcie->clk); > > - clk_prepare_enable(pcie->clk); > + ret = clk_prepare_enable(pcie->clk); > + if (ret) > + return ret; > > /* Get the dw-pcie unit configuration/control registers base. */ > base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl"); > -- > 2.7.4 >
diff --git a/drivers/pci/dwc/pcie-armada8k.c b/drivers/pci/dwc/pcie-armada8k.c index ea8f34a..7297223 100644 --- a/drivers/pci/dwc/pcie-armada8k.c +++ b/drivers/pci/dwc/pcie-armada8k.c @@ -226,7 +226,9 @@ static int armada8k_pcie_probe(struct platform_device *pdev) if (IS_ERR(pcie->clk)) return PTR_ERR(pcie->clk); - clk_prepare_enable(pcie->clk); + ret = clk_prepare_enable(pcie->clk); + if (ret) + return ret; /* Get the dw-pcie unit configuration/control registers base. */ base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");