diff mbox

[8/9] PCI: qcom: Drop unnecessary root_bus_nr setting

Message ID 1525844386-5433-8-git-send-email-shawn.guo@linaro.org (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Shawn Guo May 9, 2018, 5:39 a.m. UTC
The root_bus_nr initialization has already been done in function
dw_pcie_host_init().  The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed.  Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
---
 drivers/pci/dwc/pcie-qcom.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Stanimir Varbanov May 9, 2018, 3:46 p.m. UTC | #1
Hi Shawn,

Thanks for the patch!

On 05/09/2018 08:39 AM, Shawn Guo wrote:
> The root_bus_nr initialization has already been done in function
> dw_pcie_host_init().  The -1 assignment in platform driver before
> calling into dw_pcie_host_init() is not really needed.  Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> ---
>  drivers/pci/dwc/pcie-qcom.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 5897af7d3355..a32aa024e907 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -1247,7 +1247,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &qcom_pcie_dw_ops;
>  
>  	if (IS_ENABLED(CONFIG_PCI_MSI)) {
> 

Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
diff mbox

Patch

diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index 5897af7d3355..a32aa024e907 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -1247,7 +1247,6 @@  static int qcom_pcie_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	pp->root_bus_nr = -1;
 	pp->ops = &qcom_pcie_dw_ops;
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {