diff mbox

PCI: keystone: Do not treat link up message as error

Message ID 1525885056-7528-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Fabio Estevam May 9, 2018, 4:57 p.m. UTC
From: Fabio Estevam <fabio.estevam@nxp.com>

The "Link already up" message does not indicate any error, so
change it to dev_info() level instead.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/pci/dwc/pci-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Murali Karicheri May 11, 2018, 4:49 p.m. UTC | #1
On 05/09/2018 12:57 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The "Link already up" message does not indicate any error, so
> change it to dev_info() level instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/pci/dwc/pci-keystone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
> index d55ae07..3722a5f 100644
> --- a/drivers/pci/dwc/pci-keystone.c
> +++ b/drivers/pci/dwc/pci-keystone.c
> @@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
>  	dw_pcie_setup_rc(pp);
>  
>  	if (dw_pcie_link_up(pci)) {
> -		dev_err(dev, "Link already up\n");
> +		dev_info(dev, "Link already up\n");
>  		return 0;
>  	}
>  
> 
Acked-by: Murali Karicheri <m-karicheri2@ti.com>
Lorenzo Pieralisi May 14, 2018, 1:41 p.m. UTC | #2
On Wed, May 09, 2018 at 01:57:36PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The "Link already up" message does not indicate any error, so
> change it to dev_info() level instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/pci/dwc/pci-keystone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/dwc for v4.18, thanks.

Lorenzo

> diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
> index d55ae07..3722a5f 100644
> --- a/drivers/pci/dwc/pci-keystone.c
> +++ b/drivers/pci/dwc/pci-keystone.c
> @@ -89,7 +89,7 @@ static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
>  	dw_pcie_setup_rc(pp);
>  
>  	if (dw_pcie_link_up(pci)) {
> -		dev_err(dev, "Link already up\n");
> +		dev_info(dev, "Link already up\n");
>  		return 0;
>  	}
>  
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
index d55ae07..3722a5f 100644
--- a/drivers/pci/dwc/pci-keystone.c
+++ b/drivers/pci/dwc/pci-keystone.c
@@ -89,7 +89,7 @@  static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie)
 	dw_pcie_setup_rc(pp);
 
 	if (dw_pcie_link_up(pci)) {
-		dev_err(dev, "Link already up\n");
+		dev_info(dev, "Link already up\n");
 		return 0;
 	}