diff mbox series

PCI: dwc: remove unused function

Message ID 1618475577-99198-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive)
State Accepted
Headers show
Series PCI: dwc: remove unused function | expand

Commit Message

Jiapeng Chong April 15, 2021, 8:32 a.m. UTC
Fix the following clang warning:

drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
function 'pcie_app_rd' [-Wunused-function].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/pci/controller/dwc/pcie-intel-gw.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Krzysztof Wilczyński April 15, 2021, 1:32 p.m. UTC | #1
Hi,

> Fix the following clang warning:
> 
> drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
> function 'pcie_app_rd' [-Wunused-function].
[...]

Nice catch!  Thank you.

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

By the way, next time capitalise the subject line.

Krzysztof
Lorenzo Pieralisi April 15, 2021, 3:16 p.m. UTC | #2
On Thu, 15 Apr 2021 16:32:57 +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> drivers/pci/controller/dwc/pcie-intel-gw.c:84:19: warning: unused
> function 'pcie_app_rd' [-Wunused-function].

Applied to pci/dwc, thanks!

[1/1] PCI: dwc/intel-gw: Remove unused function
      https://git.kernel.org/lpieralisi/pci/c/9534286be3

Thanks,
Lorenzo
diff mbox series

Patch

diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
index 0cedd1f..f89a7d2 100644
--- a/drivers/pci/controller/dwc/pcie-intel-gw.c
+++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
@@ -81,11 +81,6 @@  static void pcie_update_bits(void __iomem *base, u32 ofs, u32 mask, u32 val)
 		writel(val, base + ofs);
 }
 
-static inline u32 pcie_app_rd(struct intel_pcie_port *lpp, u32 ofs)
-{
-	return readl(lpp->app_base + ofs);
-}
-
 static inline void pcie_app_wr(struct intel_pcie_port *lpp, u32 ofs, u32 val)
 {
 	writel(val, lpp->app_base + ofs);