| Message ID | 1722218205-10683-3-git-send-email-hongxing.zhu@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | Add dbi2 and atu for i.MX8M PCIe EP | expand |
On Mon, Jul 29, 2024 at 09:56:43AM +0800, Richard Zhu wrote: > Add dbi2 and iatu reg for i.MX8MQ PCIe EP. > > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the > driver. This method is not good. > > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), > Frank suggests to fetch the dbi2 and atu from DT directly. This commit is > preparation to do that for i.MX8MQ PCIe EP. > > These changes wouldn't break driver function. When "dbi2" and "atu" > properties are present, i.MX PCIe driver would fetch the according base > addresses from DT directly. If only two reg properties are provided, i.MX > PCIe driver would fall back to the old method. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > Reviewed-by: Frank Li <Frank.Li@nxp.com> "arm64: dts: ..." for subject prefix. Shawn
> -----Original Message----- > From: Shawn Guo <shawnguo2@yeah.net> > Sent: 2024年8月13日 10:51 > To: Hongxing Zhu <hongxing.zhu@nxp.com> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > shawnguo@kernel.org; l.stach@pengutronix.de; devicetree@vger.kernel.org; > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de; imx@lists.linux.dev > Subject: Re: [PATCH v4 2/4] dts: arm64: imx8mq: Add dbi2 and atu reg for > i.MX8MQ PCIe EP > > On Mon, Jul 29, 2024 at 09:56:43AM +0800, Richard Zhu wrote: > > Add dbi2 and iatu reg for i.MX8MQ PCIe EP. > > > > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the > > driver. This method is not good. > > > > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), > > Frank suggests to fetch the dbi2 and atu from DT directly. This commit > > is preparation to do that for i.MX8MQ PCIe EP. > > > > These changes wouldn't break driver function. When "dbi2" and "atu" > > properties are present, i.MX PCIe driver would fetch the according > > base addresses from DT directly. If only two reg properties are > > provided, i.MX PCIe driver would fall back to the old method. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > Reviewed-by: Frank Li <Frank.Li@nxp.com> > > "arm64: dts: ..." for subject prefix. Sorry, would be correct in v5. Best Regards Richard Zhu > > Shawn
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index e03186bbc415..d51de8d899b2 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -1819,9 +1819,11 @@ pcie1: pcie@33c00000 { pcie1_ep: pcie-ep@33c00000 { compatible = "fsl,imx8mq-pcie-ep"; - reg = <0x33c00000 0x000400000>, - <0x20000000 0x08000000>; - reg-names = "dbi", "addr_space"; + reg = <0x33c00000 0x100000>, + <0x20000000 0x8000000>, + <0x33d00000 0x100000>, + <0x33f00000 0x100000>; + reg-names = "dbi", "addr_space", "dbi2", "atu"; num-lanes = <1>; interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "dma";
Add dbi2 and iatu reg for i.MX8MQ PCIe EP. For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the driver. This method is not good. In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), Frank suggests to fetch the dbi2 and atu from DT directly. This commit is preparation to do that for i.MX8MQ PCIe EP. These changes wouldn't break driver function. When "dbi2" and "atu" properties are present, i.MX PCIe driver would fetch the according base addresses from DT directly. If only two reg properties are provided, i.MX PCIe driver would fall back to the old method. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)