| Message ID | 1733900293-169419-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] PCI: Add Rockchip vendor ID | expand |
On Wed, Dec 11, 2024 at 02:58:12PM +0800, Shawn Lin wrote: Needs a commit log. It's OK to repeat the subject line. Also, per the note at the top of pci_ids.h, needs a list of multiple places this will be used. This series only adds one place, which isn't enough to justify adding this to pci_ids.h. But this *could* also be used in drivers/misc/pci_endpoint_test.c and drivers/pci/controller/pcie-rockchip-host.c, so if you want to update them as well, this would be fine. > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > Changes in v2: None > > include/linux/pci_ids.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index d2402bf..6f68267 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2604,6 +2604,8 @@ > > #define PCI_VENDOR_ID_ZHAOXIN 0x1d17 > > +#define PCI_VENDOR_ID_ROCKCHIP 0x1d87 > + > #define PCI_VENDOR_ID_HYGON 0x1d94 > > #define PCI_VENDOR_ID_META 0x1d9b > -- > 2.7.4 >
在 2024/12/12 4:18, Bjorn Helgaas 写道: > On Wed, Dec 11, 2024 at 02:58:12PM +0800, Shawn Lin wrote: > > Needs a commit log. It's OK to repeat the subject line. > > Also, per the note at the top of pci_ids.h, needs a list of multiple > places this will be used. This series only adds one place, which > isn't enough to justify adding this to pci_ids.h. > > But this *could* also be used in drivers/misc/pci_endpoint_test.c and > drivers/pci/controller/pcie-rockchip-host.c, so if you want to update > them as well, this would be fine. > Sure, will replace them on the next version. Thanks. >> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> >> --- >> >> Changes in v2: None >> >> include/linux/pci_ids.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index d2402bf..6f68267 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -2604,6 +2604,8 @@ >> >> #define PCI_VENDOR_ID_ZHAOXIN 0x1d17 >> >> +#define PCI_VENDOR_ID_ROCKCHIP 0x1d87 >> + >> #define PCI_VENDOR_ID_HYGON 0x1d94 >> >> #define PCI_VENDOR_ID_META 0x1d9b >> -- >> 2.7.4 >> >
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d2402bf..6f68267 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2604,6 +2604,8 @@ #define PCI_VENDOR_ID_ZHAOXIN 0x1d17 +#define PCI_VENDOR_ID_ROCKCHIP 0x1d87 + #define PCI_VENDOR_ID_HYGON 0x1d94 #define PCI_VENDOR_ID_META 0x1d9b
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- Changes in v2: None include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+)