diff mbox

SB600 for the Nemo board has non-zero devices on non-root bus

Message ID 1d5276c3-1d29-114a-c868-6f022eee58e7@xenosoft.de (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Christian Zigotzky Dec. 6, 2017, 8:37 a.m. UTC 
On 03 December 2017 10:43AM, Christian Zigotzky wrote:
 >
 > On 3. Dec 2017, at 00:02, Olof Johansson <olof@lixom.net> wrote:
 >>
 >>> On Sat, Dec 2, 2017 at 3:00 PM, Olof Johansson <olof@lixom.net> wrote:
 >>>
 >>> The below patch, together with Bjorn's, should do it. Christian, 
can you test
 >>> and report back?
 >>>
 >>> I'm guessing it won't do any harm to set this on non-X1000 
platforms. My
 >>> test system is currently powered down so I can't check.
 >>>
 >>>
 >>> From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001
 >>> From: Olof Johansson <olof@lixom.net>
 >>> Date: Sat, 2 Dec 2017 14:56:36 -0800
 >>> Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS
 >>>
 >>> Needed on Amiga X1000 with SB600.
 >>>
 >>> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
 >>> Cc: Bjorn Helgaas <bhelgaas@google.com>
 >>> Signed-off-by: Olof Johansson <olof@lixom.net>
 >>> ---
 >>> arch/powerpc/platforms/pasemi/pci.c | 2 ++
 >>> 1 file changed, 2 insertions(+)
 >>>
 >>> diff --git a/arch/powerpc/platforms/pasemi/pci.c 
b/arch/powerpc/platforms/pasemi/pci.c
 >>> index 5ff6108..ea54ed2 100644
 >>> --- a/arch/powerpc/platforms/pasemi/pci.c
 >>> +++ b/arch/powerpc/platforms/pasemi/pci.c
 >>> @@ -224,6 +224,8 @@ void __init pas_pci_init(void)
 >>>                return;
 >>>        }
 >>>
 >>> +       pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS):
 >>
 >> Typo, should be ';', not ':'. I obviously didn't even try compiling 
this. :)
 >>
 >>
 >> -Olof
 >
 > Hi Olof,
 >
 > Thanks a lot for your patch! I will test it on Wednesday.
 >
 > Cheers,
 > Christian


Hi Olof,

I tested your patch today. Unfortunately the kernel 4.15-rc2 doesn't 
compile with your patch.

Error messages:

                        ^~~~~~~~~
arch/powerpc/platforms/pasemi/pci.c: In function ‘pas_pci_init’:
arch/powerpc/platforms/pasemi/pci.c:298:2: error: implicit declaration 
of function ‘pci_set_flag’ [-Werror=implicit-function-declaration]
   pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS);
   ^~~~~~~~~~~~
cc1: some warnings being treated as errors

---

I figured out that we need 'pci_set_flags' instead of 'pci_set_flag'. I 
modified your patch and after that the kernel compiles. Please find 
attached the new patch.

Cheers,
Christian
diff mbox

Patch

arch/powerpc/platforms/pasemi/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
index 5ff6108..ea54ed2 100644
--- a/arch/powerpc/platforms/pasemi/pci.c
+++ b/arch/powerpc/platforms/pasemi/pci.c
@@ -224,6 +224,8 @@  void __init pas_pci_init(void)
 		return;
 	}
 
+	pci_set_flags(PCI_SCAN_ALL_PCIE_DEVS);
+
 	for (np = NULL; (np = of_get_next_child(root, np)) != NULL;)
 		if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np))
 			of_node_get(np);