| Message ID | 20130422231221.32621.95466.stgit@bhelgaas-glaptop (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
[+cc Jeremy, xen-devel] On Mon, Apr 22, 2013 at 5:12 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: > PCI_MSIX_FLAGS_BIRMASK is mis-named because the BIR mask is in the > Table Offset register, not the flags ("Message Control" per spec) > register. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > arch/x86/pci/xen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c > index 0e8a196..b9d1ff2 100644 > --- a/arch/x86/pci/xen.c > +++ b/arch/x86/pci/xen.c > @@ -299,7 +299,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > > pci_read_config_dword(dev, pos + PCI_MSIX_TABLE, > &table_offset); > - bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK); > + bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR); > table_offset &= PCI_MSIX_TABLE_OFFSET; > > map_irq.table_base = pci_resource_start(dev, bir) + > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index 0e8a196..b9d1ff2 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -299,7 +299,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) pci_read_config_dword(dev, pos + PCI_MSIX_TABLE, &table_offset); - bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK); + bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR); table_offset &= PCI_MSIX_TABLE_OFFSET; map_irq.table_base = pci_resource_start(dev, bir) +
PCI_MSIX_FLAGS_BIRMASK is mis-named because the BIR mask is in the Table Offset register, not the flags ("Message Control" per spec) register. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- arch/x86/pci/xen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html