diff mbox

PCI: update MSI attribute file documentation

Message ID 20131203033712.GA8525@kroah.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Greg KH Dec. 3, 2013, 3:37 a.m. UTC
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Now that the MSI modes are now attribute files in sysfs, not
subdirectories, update the documentation to reflect this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Bjorn Helgaas Dec. 3, 2013, 6:23 p.m. UTC | #1
On Mon, Dec 2, 2013 at 8:37 PM, Greg KH <greg@kroah.com> wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Now that the MSI modes are now attribute files in sysfs, not
> subdirectories, update the documentation to reflect this.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks, I'll fold this into the patch that makes the code change, if
you don't mind.

Bjorn

> diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci
> index 5210a51c90fd..a3c5a6685036 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci
> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -70,18 +70,15 @@ Date:               September, 2011
>  Contact:       Neil Horman <nhorman@tuxdriver.com>
>  Description:
>                 The /sys/devices/.../msi_irqs directory contains a variable set
> -               of sub-directories, with each sub-directory being named after a
> -               corresponding msi irq vector allocated to that device.  Each
> -               numbered sub-directory N contains attributes of that irq.
> -               Note that this directory is not created for device drivers which
> -               do not support msi irqs
> +               of files, with each file being named after a corresponding msi
> +               irq vector allocated to that device.
>
> -What:          /sys/bus/pci/devices/.../msi_irqs/<N>/mode
> +What:          /sys/bus/pci/devices/.../msi_irqs/<N>
>  Date:          September 2011
>  Contact:       Neil Horman <nhorman@tuxdriver.com>
>  Description:
>                 This attribute indicates the mode that the irq vector named by
> -               the parent directory is in (msi vs. msix)
> +               the file is in (msi vs. msix)
>
>  What:          /sys/bus/pci/devices/.../remove
>  Date:          January 2009
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg KH Dec. 3, 2013, 6:36 p.m. UTC | #2
On Tue, Dec 03, 2013 at 11:23:51AM -0700, Bjorn Helgaas wrote:
> On Mon, Dec 2, 2013 at 8:37 PM, Greg KH <greg@kroah.com> wrote:
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Now that the MSI modes are now attribute files in sysfs, not
> > subdirectories, update the documentation to reflect this.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Thanks, I'll fold this into the patch that makes the code change, if
> you don't mind.

I don't mind at all, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci
index 5210a51c90fd..a3c5a6685036 100644
--- a/Documentation/ABI/testing/sysfs-bus-pci
+++ b/Documentation/ABI/testing/sysfs-bus-pci
@@ -70,18 +70,15 @@  Date:		September, 2011
 Contact:	Neil Horman <nhorman@tuxdriver.com>
 Description:
 		The /sys/devices/.../msi_irqs directory contains a variable set
-		of sub-directories, with each sub-directory being named after a
-		corresponding msi irq vector allocated to that device.  Each
-		numbered sub-directory N contains attributes of that irq.
-		Note that this directory is not created for device drivers which
-		do not support msi irqs
+		of files, with each file being named after a corresponding msi
+		irq vector allocated to that device.
 
-What:		/sys/bus/pci/devices/.../msi_irqs/<N>/mode
+What:		/sys/bus/pci/devices/.../msi_irqs/<N>
 Date:		September 2011
 Contact:	Neil Horman <nhorman@tuxdriver.com>
 Description:
 		This attribute indicates the mode that the irq vector named by
-		the parent directory is in (msi vs. msix)
+		the file is in (msi vs. msix)
 
 What:		/sys/bus/pci/devices/.../remove
 Date:		January 2009