| Message ID | 20140226234208.18970.41395.stgit@bhelgaas-glaptop.roam.corp.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On 2/26/2014 6:42 PM, Bjorn Helgaas wrote: > We don't need anything arch-specific in pcibios_enable_device(), so drop > the arch implementation and use the default generic one. > > Note: pci_enable_resources() checks that r->parent is non-NULL, which > basically checks that pci_claim_resource() or request_resource() has been > called for each BAR. I don't see where that happens for tile, but this > patch doesn't change that behavior, so if it worked before, it should still > work. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > CC: Chris Metcalf <cmetcalf@tilera.com> > --- > arch/tile/kernel/pci_gx.c | 12 ------------ > 1 file changed, 12 deletions(-) > Acked-by: Chris Metcalf <cmetcalf@tilera.com>
diff --git a/arch/tile/kernel/pci_gx.c b/arch/tile/kernel/pci_gx.c index a97a6452b812..077b7bc437e5 100644 --- a/arch/tile/kernel/pci_gx.c +++ b/arch/tile/kernel/pci_gx.c @@ -1065,18 +1065,6 @@ char *__init pcibios_setup(char *str) } /* - * Enable memory address decoding, as appropriate, for the - * device described by the 'dev' struct. - * - * This is called from the generic PCI layer, and can be called - * for bridges or endpoints. - */ -int pcibios_enable_device(struct pci_dev *dev, int mask) -{ - return pci_enable_resources(dev, mask); -} - -/* * Called for each device after PCI setup is done. * We initialize the PCI device capabilities conservatively, assuming that * all devices can only address the 32-bit DMA space. The exception here is
We don't need anything arch-specific in pcibios_enable_device(), so drop the arch implementation and use the default generic one. Note: pci_enable_resources() checks that r->parent is non-NULL, which basically checks that pci_claim_resource() or request_resource() has been called for each BAR. I don't see where that happens for tile, but this patch doesn't change that behavior, so if it worked before, it should still work. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: Chris Metcalf <cmetcalf@tilera.com> --- arch/tile/kernel/pci_gx.c | 12 ------------ 1 file changed, 12 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html