| Message ID | 20140307074932.GC2670@dhcp-26-207.brq.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Function pci_enable_msix() returns a tri-state value while > pci_enable_msi_exact() is a canonical zero/-errno variant. > The former is being phased out in favor of the latter. > In case of 'ioat' there (should be) no difference. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: dmaengine@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Acked-by: Dan Williams <dan.j.williams@intel.com> Hi Dan, Would you pick this patch, please? Thanks!
On Mon, Aug 25, 2014 at 9:35 AM, Alexander Gordeev <agordeev@redhat.com> wrote: > On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be updated to use the >> new pci_enable_msi_range() or pci_enable_msi_exact() >> and pci_enable_msix_range() or pci_enable_msix_exact() >> interfaces. > > Dan, Vinod, > > This patch hangs in -next for quite some time. > Would you release it, please? On its way... apologies for the delay. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Dan, Vinod, This patch hangs in -next for quite some time. Would you release it, please? Thanks! > Function pci_enable_msix() returns a tri-state value while > pci_enable_msi_exact() is a canonical zero/-errno variant. > The former is being phased out in favor of the latter. > In case of 'ioat' there (should be) no difference. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: dmaengine@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Acked-by: Dan Williams <dan.j.williams@intel.com> > --- > drivers/dma/ioat/dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c > index 4e3549a..b76c148 100644 > --- a/drivers/dma/ioat/dma.c > +++ b/drivers/dma/ioat/dma.c > @@ -947,7 +947,7 @@ msix: > for (i = 0; i < msixcnt; i++) > device->msix_entries[i].entry = i; > > - err = pci_enable_msix(pdev, device->msix_entries, msixcnt); > + err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt); > if (err) > goto msi; > > -- > 1.7.7.6 > > -- > Regards, > Alexander Gordeev > agordeev@redhat.com
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index 4e3549a..b76c148 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -947,7 +947,7 @@ msix: for (i = 0; i < msixcnt; i++) device->msix_entries[i].entry = i; - err = pci_enable_msix(pdev, device->msix_entries, msixcnt); + err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt); if (err) goto msi;