| Message ID | 20161026180134.23495.27520.stgit@gimli.home (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wed, Oct 26, 2016 at 12:01:34PM -0600, Alex Williamson wrote: > Allow other parts of the kernel to see which PCI ACS flags the IOMMU > layer considers necessary for isolation. > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> > Cc: Joerg Roedel <joro@8bytes.org> > --- > drivers/iommu/iommu.c | 18 +++++------------- > include/linux/iommu.h | 11 +++++++++++ > 2 files changed, 16 insertions(+), 13 deletions(-) Applied, thanks Alex. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 10, 2016 at 01:27:13PM +0100, Joerg Roedel wrote: > On Wed, Oct 26, 2016 at 12:01:34PM -0600, Alex Williamson wrote: > > Allow other parts of the kernel to see which PCI ACS flags the IOMMU > > layer considers necessary for isolation. > > > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> > > Cc: Joerg Roedel <joro@8bytes.org> > > --- > > drivers/iommu/iommu.c | 18 +++++------------- > > include/linux/iommu.h | 11 +++++++++++ > > 2 files changed, 16 insertions(+), 13 deletions(-) > > Applied, thanks Alex. Hi Joerg, did you apply just this one (4/5), or the whole series? If the former, is it safe for me to apply 1, 2, 3, and 5? I assumed these were meant to go as a group. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 11, 2016 at 04:57:40PM -0600, Bjorn Helgaas wrote: > On Thu, Nov 10, 2016 at 01:27:13PM +0100, Joerg Roedel wrote: > > On Wed, Oct 26, 2016 at 12:01:34PM -0600, Alex Williamson wrote: > > > Allow other parts of the kernel to see which PCI ACS flags the IOMMU > > > layer considers necessary for isolation. > > > > > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> > > > Cc: Joerg Roedel <joro@8bytes.org> > > > --- > > > drivers/iommu/iommu.c | 18 +++++------------- > > > include/linux/iommu.h | 11 +++++++++++ > > > 2 files changed, 16 insertions(+), 13 deletions(-) > > > > Applied, thanks Alex. > > Hi Joerg, did you apply just this one (4/5), or the whole series? If the > former, is it safe for me to apply 1, 2, 3, and 5? I assumed these were > meant to go as a group. Ah yes, I missed that this patch was part of a series and applied it. I can still remove it, as the tree is not yet pushed. Will you take the while series? Then you can add my Acked-by: Joerg Roedel <jroedel@suse.de> to this patch. Thanks, Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index b06d935..f73e6f4 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -610,16 +610,6 @@ static struct iommu_group *get_pci_alias_group(struct pci_dev *pdev, unsigned long *devfns); /* - * To consider a PCI device isolated, we require ACS to support Source - * Validation, Request Redirection, Completer Redirection, and Upstream - * Forwarding. This effectively means that devices cannot spoof their - * requester ID, requests and completions cannot be redirected, and all - * transactions are forwarded upstream, even as it passes through a - * bridge where the target device is downstream. - */ -#define REQ_ACS_FLAGS (PCI_ACS_SV | PCI_ACS_RR | PCI_ACS_CR | PCI_ACS_UF) - -/* * For multifunction devices which are not isolated from each other, find * all the other non-isolated functions and look for existing groups. For * each function, we also need to look for aliases to or from other devices @@ -631,13 +621,14 @@ static struct iommu_group *get_pci_function_alias_group(struct pci_dev *pdev, struct pci_dev *tmp = NULL; struct iommu_group *group; - if (!pdev->multifunction || pci_acs_enabled(pdev, REQ_ACS_FLAGS)) + if (!pdev->multifunction || + pci_acs_enabled(pdev, IOMMU_REQ_PCI_ACS_FLAGS)) return NULL; for_each_pci_dev(tmp) { if (tmp == pdev || tmp->bus != pdev->bus || PCI_SLOT(tmp->devfn) != PCI_SLOT(pdev->devfn) || - pci_acs_enabled(tmp, REQ_ACS_FLAGS)) + pci_acs_enabled(tmp, IOMMU_REQ_PCI_ACS_FLAGS)) continue; group = get_pci_alias_group(tmp, devfns); @@ -765,7 +756,8 @@ struct iommu_group *pci_device_group(struct device *dev) if (!bus->self) continue; - if (pci_acs_path_enabled(bus->self, NULL, REQ_ACS_FLAGS)) + if (pci_acs_path_enabled(bus->self, NULL, + IOMMU_REQ_PCI_ACS_FLAGS)) break; pdev = bus->self; diff --git a/include/linux/iommu.h b/include/linux/iommu.h index a35fb8b..23f4d1d 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -131,6 +131,17 @@ struct iommu_dm_region { int prot; }; +/* + * To consider a PCI device isolated, we require ACS to support Source + * Validation, Request Redirection, Completer Redirection, and Upstream + * Forwarding. This effectively means that devices cannot spoof their + * requester ID, requests and completions cannot be redirected, and all + * transactions are forwarded upstream, even as it passes through a + * bridge where the target device is downstream. + */ +#define IOMMU_REQ_PCI_ACS_FLAGS (PCI_ACS_SV | PCI_ACS_RR | \ + PCI_ACS_CR | PCI_ACS_UF) + #ifdef CONFIG_IOMMU_API /**
Allow other parts of the kernel to see which PCI ACS flags the IOMMU layer considers necessary for isolation. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Cc: Joerg Roedel <joro@8bytes.org> --- drivers/iommu/iommu.c | 18 +++++------------- include/linux/iommu.h | 11 +++++++++++ 2 files changed, 16 insertions(+), 13 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html