| Message ID | 20180403145225.22371-10-mika.westerberg@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Tuesday, April 3, 2018 4:52:25 PM CEST Mika Westerberg wrote: > There is no need for them and it makes the code look uglier than it > should. Remove them. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/pci/hotplug/acpiphp_glue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c > index 5d7be06bba7f..ce8716c022f0 100644 > --- a/drivers/pci/hotplug/acpiphp_glue.c > +++ b/drivers/pci/hotplug/acpiphp_glue.c > @@ -524,7 +524,7 @@ static void enable_slot(struct acpiphp_slot *slot) > if (!dev) { > /* Do not set SLOT_ENABLED flag if some funcs > are not added. */ > - slot->flags &= (~SLOT_ENABLED); > + slot->flags &= ~SLOT_ENABLED; > continue; > } > } > @@ -553,7 +553,7 @@ static void disable_slot(struct acpiphp_slot *slot) > list_for_each_entry(func, &slot->funcs, sibling) > acpi_bus_trim(func_to_acpi_device(func)); > > - slot->flags &= (~SLOT_ENABLED); > + slot->flags &= ~SLOT_ENABLED; > } > > static bool slot_no_hotplug(struct acpiphp_slot *slot) > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 5d7be06bba7f..ce8716c022f0 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -524,7 +524,7 @@ static void enable_slot(struct acpiphp_slot *slot) if (!dev) { /* Do not set SLOT_ENABLED flag if some funcs are not added. */ - slot->flags &= (~SLOT_ENABLED); + slot->flags &= ~SLOT_ENABLED; continue; } } @@ -553,7 +553,7 @@ static void disable_slot(struct acpiphp_slot *slot) list_for_each_entry(func, &slot->funcs, sibling) acpi_bus_trim(func_to_acpi_device(func)); - slot->flags &= (~SLOT_ENABLED); + slot->flags &= ~SLOT_ENABLED; } static bool slot_no_hotplug(struct acpiphp_slot *slot)
There is no need for them and it makes the code look uglier than it should. Remove them. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/pci/hotplug/acpiphp_glue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)