| Message ID | 20190301065809.66046-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [-next] PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static | expand |
Hello Wei, On Fri, 1 Mar 2019 06:58:09 +0000 Wei Yongjun <weiyongjun1@huawei.com> wrote: > Fixes the following sparse warning: > > drivers/pci/controller/pci-aardvark.c:469:28: warning: > symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static? > > Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Thanks! Thomas
On Fri, Mar 01, 2019 at 06:58:09AM +0000, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/pci/controller/pci-aardvark.c:469:28: warning: > symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static? > > Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/pci/controller/pci-aardvark.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/misc for v5.1, thanks. Lorenzo > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > index 6eecae447af3..eb58dfdaba1b 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -466,7 +466,7 @@ advk_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, > } > } > > -struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = { > +static struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = { > .read_pcie = advk_pci_bridge_emul_pcie_conf_read, > .write_pcie = advk_pci_bridge_emul_pcie_conf_write, > }; > > >
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 6eecae447af3..eb58dfdaba1b 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -466,7 +466,7 @@ advk_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge, } } -struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = { +static struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = { .read_pcie = advk_pci_bridge_emul_pcie_conf_read, .write_pcie = advk_pci_bridge_emul_pcie_conf_write, };
Fixes the following sparse warning: drivers/pci/controller/pci-aardvark.c:469:28: warning: symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static? Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/pci/controller/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)