| Message ID | 20190614154044.4972-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 381ed79c8655a40268ee7391f716edd90c5c3a97 |
| Headers | show |
| Series | PCI: dwc: pci-dra7xx: Add missing include file | expand |
On Fri, Jun 14, 2019 at 11:40:44PM +0800, YueHaibing wrote: > Fix build error: > > drivers/pci/controller/dwc/pci-dra7xx.c: > In function dra7xx_pcie_probe: > drivers/pci/controller/dwc/pci-dra7xx.c:777:10: > error: implicit declaration of function devm_gpiod_get_optional; > did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration] > > reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH); Adding the reason (in particular the config options) that triggers this error would not hurt. Kishon please let me know if I can merge it (ACK it if so). Thanks, Lorenzo > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > index 419451e..4234ddb 100644 > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > @@ -26,6 +26,7 @@ > #include <linux/types.h> > #include <linux/mfd/syscon.h> > #include <linux/regmap.h> > +#include <linux/gpio/consumer.h> > > #include "../../pci.h" > #include "pcie-designware.h" > -- > 2.7.4 > >
On 05/07/19 8:59 PM, Lorenzo Pieralisi wrote: > On Fri, Jun 14, 2019 at 11:40:44PM +0800, YueHaibing wrote: >> Fix build error: >> >> drivers/pci/controller/dwc/pci-dra7xx.c: >> In function dra7xx_pcie_probe: >> drivers/pci/controller/dwc/pci-dra7xx.c:777:10: >> error: implicit declaration of function devm_gpiod_get_optional; >> did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration] >> >> reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH); > > Adding the reason (in particular the config options) that triggers > this error would not hurt. > > Kishon please let me know if I can merge it (ACK it if so). Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > > Thanks, > Lorenzo > >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/pci/controller/dwc/pci-dra7xx.c | 1 + >> 1 file changed, 1 insertion(+) > > >> >> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c >> index 419451e..4234ddb 100644 >> --- a/drivers/pci/controller/dwc/pci-dra7xx.c >> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c >> @@ -26,6 +26,7 @@ >> #include <linux/types.h> >> #include <linux/mfd/syscon.h> >> #include <linux/regmap.h> >> +#include <linux/gpio/consumer.h> >> >> #include "../../pci.h" >> #include "pcie-designware.h" >> -- >> 2.7.4 >> >>
On Fri, Jun 14, 2019 at 11:40:44PM +0800, YueHaibing wrote: > Fix build error: > > drivers/pci/controller/dwc/pci-dra7xx.c: > In function dra7xx_pcie_probe: > drivers/pci/controller/dwc/pci-dra7xx.c:777:10: > error: implicit declaration of function devm_gpiod_get_optional; > did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration] > > reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH); > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 1 + > 1 file changed, 1 insertion(+) Applied to pci/dwc for v5.3, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > index 419451e..4234ddb 100644 > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > @@ -26,6 +26,7 @@ > #include <linux/types.h> > #include <linux/mfd/syscon.h> > #include <linux/regmap.h> > +#include <linux/gpio/consumer.h> > > #include "../../pci.h" > #include "pcie-designware.h" > -- > 2.7.4 > >
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 419451e..4234ddb 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -26,6 +26,7 @@ #include <linux/types.h> #include <linux/mfd/syscon.h> #include <linux/regmap.h> +#include <linux/gpio/consumer.h> #include "../../pci.h" #include "pcie-designware.h"
Fix build error: drivers/pci/controller/dwc/pci-dra7xx.c: In function dra7xx_pcie_probe: drivers/pci/controller/dwc/pci-dra7xx.c:777:10: error: implicit declaration of function devm_gpiod_get_optional; did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration] reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH); Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/pci/controller/dwc/pci-dra7xx.c | 1 + 1 file changed, 1 insertion(+)