| Message ID | 20190730163545.4915-14-logang@deltatee.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | PCI/P2PDMA: Support transactions that hit the host bridge | expand |
no-mmu sounds stange, as we use that for linux ports without paging hardware. I think an "io" got lost somewhere..
On Wed, Aug 07, 2019 at 07:59:58AM +0200, Christoph Hellwig wrote: > no-mmu sounds stange, as we use that for linux ports without paging > hardware. I think an "io" got lost somewhere.. I had already changed the subject to PCI/P2PDMA: Allow IOMMU for host bridge whitelist but certainly open to better suggestions.
On Wed, Aug 07, 2019 at 07:43:01AM -0500, Bjorn Helgaas wrote: > On Wed, Aug 07, 2019 at 07:59:58AM +0200, Christoph Hellwig wrote: > > no-mmu sounds stange, as we use that for linux ports without paging > > hardware. I think an "io" got lost somewhere.. > > I had already changed the subject to > > PCI/P2PDMA: Allow IOMMU for host bridge whitelist > > but certainly open to better suggestions. Maybe: PCI/P2PDMA: Allow P2P transfers behind IOMMUs ?
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c index b86a1c0c11a0..2d643b26d080 100644 --- a/drivers/pci/p2pdma.c +++ b/drivers/pci/p2pdma.c @@ -18,7 +18,6 @@ #include <linux/percpu-refcount.h> #include <linux/random.h> #include <linux/seq_buf.h> -#include <linux/iommu.h> #include <linux/xarray.h> enum pci_p2pdma_map_type { @@ -328,9 +327,6 @@ static bool host_bridge_whitelist(struct pci_dev *a, struct pci_dev *b) struct pci_host_bridge *host_a = pci_find_host_bridge(a->bus); struct pci_host_bridge *host_b = pci_find_host_bridge(b->bus); - if (iommu_present(a->dev.bus) || iommu_present(b->dev.bus)) - return false; - if (host_a == host_b) return __host_bridge_whitelist(host_a, true);
Now that we map the requests correctly we can remove the iommu_present() restriction. Signed-off-by: Logan Gunthorpe <logang@deltatee.com> --- drivers/pci/p2pdma.c | 4 ---- 1 file changed, 4 deletions(-)